Skip to content

Extract logic from find_best_candidate and find_all_candidate to static methods #9681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Martinn1996 wants to merge 16 commits into from
Closed

Extract logic from find_best_candidate and find_all_candidate to static methods #9681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b4c3697
Create static methods from find_all_candidates and the methods it calls
QuentinLee5 Mar 13, 2021
89d3329
Add tuple instead of PackageFinder for parameters
QuentinLee5 Mar 13, 2021
b112c35
Add LinkEvaluator as tuple
QuentinLee5 Mar 13, 2021
151da19
Add TODO
QuentinLee5 Mar 13, 2021
2c6b177
Remove commented code
QuentinLee5 Mar 13, 2021
ef1053f
Refactor find_best_candidate
QuentinLee5 Mar 13, 2021
0deab39
Add static function for make_candidate_evaluator
QuentinLee5 Mar 13, 2021
3f19d5a
make_candidate_evaluator calls static method
QuentinLee5 Mar 13, 2021
239222a
Resolve linting errors
QuentinLee5 Mar 14, 2021
2f5b9a4
Extract logic from find_best_candidate and find_all_candidate to stat…
Martinn1996 Mar 3, 2021
fcdfb33
Add 9084.bugfix.rst
Martinn1996 Mar 3, 2021
be6c8d6
Remove unused code
QuentinLee5 Mar 17, 2021
e7eaede
Add code style improvements
QuentinLee5 Mar 19, 2021
28b08a0
Update self._logged_links after calling static function
QuentinLee5 Mar 20, 2021
c8da7b9
Use collect_sources instead of collect_links
QuentinLee5 Apr 24, 2021
94a491e
Fix linting errors
QuentinLee5 Apr 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/9084.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Extract the logic from package_finder.find_best_candidate and package_finder.find_all_candidate to static methods.
Loading