From fc295156dcd409ea71f8cc33b09b72431c0a5180 Mon Sep 17 00:00:00 2001 From: Collin Anderson <cmawebsite@gmail.com> Date: Tue, 4 Apr 2023 13:02:23 -0400 Subject: [PATCH] Avoid parsing dist.version twice in a row dist.version is a property that parses the version string each time, so it's slightly faster to only parse it once. --- src/pip/_internal/operations/freeze.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/pip/_internal/operations/freeze.py b/src/pip/_internal/operations/freeze.py index 930d4c6005e..35445684514 100644 --- a/src/pip/_internal/operations/freeze.py +++ b/src/pip/_internal/operations/freeze.py @@ -145,9 +145,10 @@ def freeze( def _format_as_name_version(dist: BaseDistribution) -> str: - if isinstance(dist.version, Version): - return f"{dist.raw_name}=={dist.version}" - return f"{dist.raw_name}==={dist.version}" + dist_version = dist.version + if isinstance(dist_version, Version): + return f"{dist.raw_name}=={dist_version}" + return f"{dist.raw_name}==={dist_version}" def _get_editable_info(dist: BaseDistribution) -> _EditableInfo: