Update self._logged_links after calling static function

Author: QuentinLee5

src/pip/_internal/index/package_finder.py

@@ -909,7 +909,7 @@ def _find_all_candidates_static(
         link_evaluator_tuple,   # type: LinkEvaluatorTuple
         project_name            # type: str
     ):
-        # type: (...) -> List[InstallationCandidate]
+        # type: (...) -> Tuple[List[InstallationCandidate], Set[Link]]
         """Find all available InstallationCandidate for project_name
 
         This checks index_urls and find_links.
@@ -919,15 +919,13 @@ def _find_all_candidates_static(
         are accepted.
         """
 
-        # Need to convert logged_links to normal set, so we can update it.
         package_finder_tuple = PackageFinderTuple(
             logged_links=set(package_finder_tuple.logged_links),
             link_collector=package_finder_tuple.link_collector,
             target_python=package_finder_tuple.target_python,
             candidate_prefs=package_finder_tuple.candidate_prefs
         )
 
-        # Add link_collector to the tuple
         collected_links = package_finder_tuple.link_collector.collect_links(
             project_name
         )
@@ -938,7 +936,6 @@ def _find_all_candidates_static(
             links=collected_links.find_links,
         )
 
-        # Only needs link collector from package_finder
         page_versions = []
         for project_url in collected_links.project_urls:
             package_links = PackageFinder._process_project_url_static(
@@ -964,7 +961,10 @@ def _find_all_candidates_static(
             )
 
         # This is an intentional priority ordering
-        return file_versions + find_links_versions + page_versions
+        return (
+            file_versions + find_links_versions + page_versions,
+            package_finder_tuple.logged_links
+        )
 
     def find_all_candidates(self, project_name):
         # type: (str) -> List[InstallationCandidate]
@@ -980,12 +980,17 @@ def find_all_candidates(self, project_name):
 
         package_finder_tuple = self.get_state_as_tuple(immutable=True)
         link_evaluator_tuple = link_evaluator.get_state_as_tuple()
-        return self._find_all_candidates_static(
+
+        (candidates, logged_links) = self._find_all_candidates_static(
             package_finder_tuple,
             link_evaluator_tuple,
             project_name
         )
 
+        self._logged_links = logged_links
+
+        return candidates
+
     @staticmethod
     def _make_candidate_evaluator_static(
         package_finder_tuple,   # type: PackageFinderTuple
@@ -1030,20 +1035,20 @@ def _find_best_candidate_static(
         specifier=None,         # type: Optional[specifiers.BaseSpecifier]
         hashes=None             # type: Optional[Hashes]
     ):
-        # type: (...) -> BestCandidateResult
+        # type: (...) -> Tuple[BestCandidateResult, Set[Link]]
         candidate_evaluator = PackageFinder._make_candidate_evaluator_static(
             package_finder_tuple,
             project_name,
             specifier,
             hashes
         )
-        candidates = PackageFinder._find_all_candidates_static(
+        (candidates, logged_links) = PackageFinder._find_all_candidates_static(
             package_finder_tuple,
             link_evaluator_tuple,
             project_name
         )
 
-        return candidate_evaluator.compute_best_candidate(candidates)
+        return (candidate_evaluator.compute_best_candidate(candidates), logged_links)
 
     def find_best_candidate(
         self,
@@ -1066,14 +1071,18 @@ def find_best_candidate(
         package_finder_tuple = self.get_state_as_tuple(immutable=True)
         link_evaluator_tuple = link_evaluator.get_state_as_tuple()
 
-        return self._find_best_candidate_static(
+        (best_candidate, logged_links) = self._find_best_candidate_static(
             package_finder_tuple,
             link_evaluator_tuple,
             project_name,
             specifier,
             hashes
         )
 
+        self._logged_links = logged_links
+
+        return best_candidate
+
     def find_requirement(self, req, upgrade):
         # type: (InstallRequirement, bool) -> Optional[InstallationCandidate]
         """Try to find a Link matching req

tests/unit/test_resolution_legacy_resolver.py

@@ -180,7 +180,7 @@ class TestYankedWarning:
     """
     def _make_test_resolver(self, monkeypatch, mock_candidates):
         def _find_candidates(package_finder, link_evaluator, project_name):
-            return mock_candidates
+            return (mock_candidates, [])
 
         finder = make_test_finder()
         monkeypatch.setattr(