Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 3a157bb

Browse files
committedNov 10, 2024·
Fix type hints for resolvelib 1.1.0
1 parent 9308566 commit 3a157bb

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed
 

‎src/pip/_internal/resolution/resolvelib/factory.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -748,7 +748,7 @@ def get_installation_error(
748748
# The simplest case is when we have *one* cause that can't be
749749
# satisfied. We just report that case.
750750
if len(e.causes) == 1:
751-
req, parent = e.causes[0]
751+
req, parent = next(iter(e.causes))
752752
if req.name not in constraints:
753753
return self._report_single_requirement_conflict(req, parent)
754754

‎src/pip/_internal/resolution/resolvelib/reporter.py

+6-4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from collections import defaultdict
22
from logging import getLogger
3-
from typing import Any, DefaultDict
3+
from typing import Any, DefaultDict, Optional
44

55
from pip._vendor.resolvelib.reporters import BaseReporter
66

@@ -9,7 +9,7 @@
99
logger = getLogger(__name__)
1010

1111

12-
class PipReporter(BaseReporter):
12+
class PipReporter(BaseReporter[Requirement, Candidate, str]):
1313
def __init__(self) -> None:
1414
self.reject_count_by_package: DefaultDict[str, int] = defaultdict(int)
1515

@@ -55,7 +55,7 @@ def rejecting_candidate(self, criterion: Any, candidate: Candidate) -> None:
5555
logger.debug(msg)
5656

5757

58-
class PipDebuggingReporter(BaseReporter):
58+
class PipDebuggingReporter(BaseReporter[Requirement, Candidate, str]):
5959
"""A reporter that does an info log for every event it sees."""
6060

6161
def starting(self) -> None:
@@ -71,7 +71,9 @@ def ending_round(self, index: int, state: Any) -> None:
7171
def ending(self, state: Any) -> None:
7272
logger.info("Reporter.ending(%r)", state)
7373

74-
def adding_requirement(self, requirement: Requirement, parent: Candidate) -> None:
74+
def adding_requirement(
75+
self, requirement: Requirement, parent: Optional[Candidate]
76+
) -> None:
7577
logger.info("Reporter.adding_requirement(%r, %r)", requirement, parent)
7678

7779
def rejecting_candidate(self, criterion: Any, candidate: Candidate) -> None:

‎src/pip/_internal/resolution/resolvelib/resolver.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ def resolve(
8282
user_requested=collected.user_requested,
8383
)
8484
if "PIP_RESOLVER_DEBUG" in os.environ:
85-
reporter: BaseReporter = PipDebuggingReporter()
85+
reporter: BaseReporter[Requirement, Candidate, str] = PipDebuggingReporter()
8686
else:
8787
reporter = PipReporter()
8888
resolver: RLResolver[Requirement, Candidate, str] = RLResolver(

0 commit comments

Comments
 (0)
Please sign in to comment.