Move dependency-group logic to hatch

Dependency groups have no impact on binary distributions so moved to build frontend.

Author: djcopley

backend/src/hatchling/metadata/core.py

@@ -2,7 +2,6 @@
 
 import os
 import sys
-from collections import defaultdict
 from contextlib import suppress
 from copy import deepcopy
 from typing import TYPE_CHECKING, Any, Generic, cast
@@ -53,8 +52,6 @@ def __init__(
         self._core: CoreMetadata | None = None
         self._hatch: HatchMetadata | None = None
 
-        self._dependency_groups: dict[str, list[str]] | None = None
-
         self._core_raw_metadata: dict[str, Any] | None = None
         self._dynamic: list[str] | None = None
         self._name: str | None = None
@@ -80,38 +77,6 @@ def context(self) -> Context:
 
         return self._context
 
-    @property
-    def dependency_groups(self) -> dict[str, Any]:
-        """
-        https://peps.python.org/pep-0735/
-        """
-        if self._dependency_groups is None:
-            dependency_groups = self.config.get('dependency-groups', {})
-
-            if not isinstance(dependency_groups, dict):
-                message = 'Field `dependency-groups` must be a table'
-                raise ValueError(message)
-
-            original_names = defaultdict(list)
-            normalized_groups = {}
-
-            for group_name, value in dependency_groups.items():
-                normed_group_name = normalize_project_name(group_name)
-                original_names[normed_group_name].append(group_name)
-                normalized_groups[normed_group_name] = value
-
-            errors = []
-            for normed_name, names in original_names.items():
-                if len(names) > 1:
-                    errors.append(f"{normed_name} ({', '.join(names)})")
-            if errors:
-                msg = f"Field `dependency-groups` contains duplicate names: {', '.join(errors)}"
-                raise ValueError(msg)
-
-            self._dependency_groups = dependency_groups
-
-        return self._dependency_groups
-
     @property
     def core_raw_metadata(self) -> dict[str, Any]:
         if self._core_raw_metadata is None:

src/hatch/env/plugin/interface.py

@@ -310,7 +310,7 @@ def dependencies_complex(self):
 
             for dependency_group in self.dependency_groups:
                 all_dependencies_complex.extend(
-                    get_complex_dependency_group(self.metadata.dependency_groups, dependency_group)
+                    get_complex_dependency_group(self.app.project.dependency_groups, dependency_group)
                 )
 
         return all_dependencies_complex
@@ -453,7 +453,7 @@ def dependency_groups(self):
             normalized_dependency_group = normalize_project_name(dependency_group)
             if (
                 not self.metadata.hatch.metadata.hook_config
-                and normalized_dependency_group not in self.metadata.dependency_groups
+                and normalized_dependency_group not in self.app.project.dependency_groups
             ):
                 message = (
                     f'Dependency Group `{normalized_dependency_group}` of field `tool.hatch.envs.{self.name}.dependency-groups` is not '

src/hatch/project/core.py

@@ -1,9 +1,10 @@
 from __future__ import annotations
 
 import re
+from collections import defaultdict
 from contextlib import contextmanager
 from functools import cached_property
-from typing import TYPE_CHECKING, Generator, cast
+from typing import TYPE_CHECKING, Any, Generator, cast
 
 from hatch.project.env import EnvironmentMetadata
 from hatch.utils.fs import Path
@@ -103,6 +104,37 @@ def build_frontend(self) -> BuildFrontend:
     def env_metadata(self) -> EnvironmentMetadata:
         return EnvironmentMetadata(self.app.data_dir / 'env' / '.metadata', self.location)
 
+    @cached_property
+    def dependency_groups(self) -> dict[str, Any]:
+        """
+        https://peps.python.org/pep-0735/
+        """
+        from hatchling.metadata.utils import normalize_project_name
+
+        dependency_groups = self.raw_config.get('dependency-groups', {})
+
+        if not isinstance(dependency_groups, dict):
+            message = 'Field `dependency-groups` must be a table'
+            raise TypeError(message)
+
+        original_names = defaultdict(list)
+        normalized_groups = {}
+
+        for group_name, value in dependency_groups.items():
+            normed_group_name = normalize_project_name(group_name)
+            original_names[normed_group_name].append(group_name)
+            normalized_groups[normed_group_name] = value
+
+        errors = []
+        for normed_name, names in original_names.items():
+            if len(names) > 1:
+                errors.append(f"{normed_name} ({', '.join(names)})")
+        if errors:
+            msg = f"Field `dependency-groups` contains duplicate names: {', '.join(errors)}"
+            raise ValueError(msg)
+
+        return normalized_groups
+
     def get_environment(self, env_name: str | None = None) -> EnvironmentInterface:
         if env_name is None:
             env_name = self.app.env

tests/env/plugin/test_interface.py

@@ -793,13 +793,15 @@ def test_not_array(self, isolation, isolated_data_dir, platform, global_applicat
         ):
             _ = environment.dependency_groups
 
-    def test_correct(self, isolation, isolated_data_dir, platform, global_application):
+    def test_correct(self, isolation, isolated_data_dir, platform, temp_application):
         config = {
             'project': {'name': 'my_app', 'version': '0.0.1'},
             'dependency-groups': {'foo-bar': [], 'baz': []},
             'tool': {'hatch': {'envs': {'default': {'dependency-groups': ['Foo...Bar', 'Baz', 'baZ']}}}},
         }
         project = Project(isolation, config=config)
+        project.set_app(temp_application)
+        temp_application.project = project
         environment = MockEnvironment(
             isolation,
             project.metadata,
@@ -810,7 +812,7 @@ def test_correct(self, isolation, isolated_data_dir, platform, global_applicatio
             isolated_data_dir,
             platform,
             0,
-            global_application,
+            temp_application,
         )
 
         assert environment.dependency_groups == ['baz', 'foo-bar']
@@ -865,7 +867,7 @@ def test_group_empty_string(self, isolation, isolated_data_dir, platform, global
         ):
             _ = environment.dependency_groups
 
-    def test_group_undefined(self, isolation, isolated_data_dir, platform, global_application):
+    def test_group_undefined(self, isolation, isolated_data_dir, platform, temp_application):
         config = {
             'project': {
                 'name': 'my_app',
@@ -875,6 +877,8 @@ def test_group_undefined(self, isolation, isolated_data_dir, platform, global_ap
             'tool': {'hatch': {'envs': {'default': {'dependency-groups': ['foo', 'bar', '']}}}},
         }
         project = Project(isolation, config=config)
+        project.set_app(temp_application)
+        temp_application.project = project
         environment = MockEnvironment(
             isolation,
             project.metadata,
@@ -885,7 +889,7 @@ def test_group_undefined(self, isolation, isolated_data_dir, platform, global_ap
             isolated_data_dir,
             platform,
             0,
-            global_application,
+            temp_application,
         )
 
         with pytest.raises(