Update PyMC tutorial notebooks with improvements and fixes #7938
+634
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
- Remove VarName NewType definition from util.py - Replace all VarName type hints with str - Simplify get_var_name function to use var.name directly - Update imports in model_graph.py and model/core.py - Fix all type annotations and function signatures Resolves pymc-devs#7843
|
We don't use explicit internal links |
…vs#7891) This commit implements validation of InferenceData dimensions and coordinates consistency before pm.sample() executes, preventing cryptic shape mismatch errors during sampling. Changes: - Add pymc/model/validation.py with validation functions: * validate_dims_coords_consistency(): Main validation entry point * check_dims_exist(): Verify referenced dims exist in model.coords * check_shape_dims_match(): Verify variable shapes match declared dims * check_coord_lengths(): Verify coordinate lengths match dimension sizes - Integrate validation into pymc/sampling/mcmc.py: * Added validation call early in sample() function, before sampling setup * Provides clear, actionable error messages to guide users - Add comprehensive tests in tests/model/test_dims_coords_validation.py: * Test missing coord detection * Test shape-dims mismatch detection * Test coordinate length validation * Test MutableData, observed data, and Deterministic variables * Test edge cases and complex models Fixes pymc-devs#7891
- Fixes Issue pymc-devs#7878 - Replace pt.batched_dot(sqrt_quad.T, sqrt_quad.T) with pt.sum(sqrt_quad.T ** 2, axis=-1) - Computes squared norm per sample using modern PyTensor operations - Eliminates deprecation warnings and ensures future compatibility
|
Hi @ricardoV94 and team, I realize I've mixed multiple unrelated issues (#7843, #7891, #7878) in this single PR. I've closed this PR and created 4 focused PRs instead:
Thanks for the guidance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
✅ Updated remote URL from atheendre130505/sktime to atheendre130505/pymc
✅ Verified the changes - The commit contains improvements to three PyMC tutorial notebooks:
dimensionality.ipynb
dims_module.ipynb
pymc_overview.ipynb
✅ Changes reviewed - The modifications add proper documentation links for:
dims concepts linking to the dims module documentation
coords linking to PyMC's coordinate values API
InferenceData linking to ArviZ's InferenceData documentation
XArray linking to XArray documentation
📚 Documentation preview 📚: https://pymc--7938.org.readthedocs.build/en/7938/