Skip to content

Commit c4e283f

Browse files
AearsearsAearsears
committed
update error message to be os.environ.get and not builtins.dict
1 parent 5915efc commit c4e283f

File tree

2 files changed

+34
-34
lines changed

2 files changed

+34
-34
lines changed

‎pylint/checkers/stdlib.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -960,9 +960,9 @@ def _check_invalid_envvar_value(
960960
elif not isinstance(call_arg.value, str):
961961
emit = True
962962
if emit:
963-
self.add_message(message, node=node, args=(name, call_arg.pytype()))
963+
self.add_message(message, node=node, args=("os.environ.get" if self.is_os_environ_get(node) else name, call_arg.pytype()))
964964
else:
965-
self.add_message(message, node=node, args=(name, call_arg.pytype()))
965+
self.add_message(message, node=node, args=("os.environ.get" if self.is_os_environ_get(node) else name, call_arg.pytype()))
966966

967967
def is_os_environ_get(self, node: nodes.Call) -> bool:
968968
try:

‎tests/functional/i/invalid/invalid_envvar_value.txt‎

Lines changed: 32 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -29,35 +29,35 @@ invalid-envvar-default:80:0:80:36::os.getenv default type is builtins.bytes. Exp
2929
invalid-envvar-default:81:0:81:36::os.getenv default type is builtins.list. Expected str or None.:UNDEFINED
3030
invalid-envvar-default:82:0:82:53::os.getenv default type is builtins.list. Expected str or None.:UNDEFINED
3131
invalid-envvar-default:85:0:85:54::os.getenv default type is builtins.bytes. Expected str or None.:UNDEFINED
32-
invalid-envvar-value:89:0:89:23::builtins.dict.get does not support builtins.bytes type argument:UNDEFINED
33-
invalid-envvar-value:91:0:91:20::builtins.dict.get does not support builtins.NoneType type argument:UNDEFINED
34-
invalid-envvar-value:92:0:92:24::builtins.dict.get does not support builtins.list type argument:UNDEFINED
35-
invalid-envvar-value:93:0:93:42::builtins.dict.get does not support builtins.bytes type argument:UNDEFINED
36-
invalid-envvar-value:94:0:94:47::builtins.dict.get does not support builtins.bytes type argument:UNDEFINED
37-
invalid-envvar-value:95:0:95:41::builtins.dict.get does not support builtins.list type argument:UNDEFINED
38-
invalid-envvar-value:96:0:96:41::builtins.dict.get does not support builtins.NoneType type argument:UNDEFINED
39-
invalid-envvar-value:100:0:100:34::builtins.dict.get does not support builtins.bytes type argument:UNDEFINED
40-
invalid-envvar-value:102:0:102:31::builtins.dict.get does not support builtins.NoneType type argument:UNDEFINED
41-
invalid-envvar-value:103:0:103:35::builtins.dict.get does not support builtins.list type argument:UNDEFINED
42-
invalid-envvar-value:104:0:104:53::builtins.dict.get does not support builtins.bytes type argument:UNDEFINED
43-
invalid-envvar-value:105:0:105:52::builtins.dict.get does not support builtins.list type argument:UNDEFINED
44-
invalid-envvar-value:106:0:106:52::builtins.dict.get does not support builtins.NoneType type argument:UNDEFINED
45-
invalid-envvar-value:109:0:109:27::builtins.dict.get does not support builtins.bytes type argument:UNDEFINED
46-
invalid-envvar-value:111:0:111:24::builtins.dict.get does not support builtins.NoneType type argument:UNDEFINED
47-
invalid-envvar-value:112:0:112:28::builtins.dict.get does not support builtins.list type argument:UNDEFINED
48-
invalid-envvar-value:113:0:113:46::builtins.dict.get does not support builtins.bytes type argument:UNDEFINED
49-
invalid-envvar-value:114:0:114:45::builtins.dict.get does not support builtins.list type argument:UNDEFINED
50-
invalid-envvar-value:115:0:115:45::builtins.dict.get does not support builtins.NoneType type argument:UNDEFINED
51-
invalid-envvar-default:119:0:119:26::builtins.dict.get default type is builtins.list. Expected str or None.:UNDEFINED
52-
invalid-envvar-default:121:0:121:30::builtins.dict.get default type is builtins.bytes. Expected str or None.:UNDEFINED
53-
invalid-envvar-default:122:0:122:49::builtins.dict.get default type is builtins.list. Expected str or None.:UNDEFINED
54-
invalid-envvar-default:125:0:125:50::builtins.dict.get default type is builtins.bytes. Expected str or None.:UNDEFINED
55-
invalid-envvar-default:128:0:128:34::builtins.dict.get default type is builtins.list. Expected str or None.:UNDEFINED
56-
invalid-envvar-default:130:0:130:38::builtins.dict.get default type is builtins.bytes. Expected str or None.:UNDEFINED
57-
invalid-envvar-default:131:0:131:57::builtins.dict.get default type is builtins.list. Expected str or None.:UNDEFINED
58-
invalid-envvar-default:134:0:134:58::builtins.dict.get default type is builtins.bytes. Expected str or None.:UNDEFINED
59-
invalid-envvar-default:138:0:138:44::builtins.dict.get default type is builtins.bytes. Expected str or None.:UNDEFINED
60-
invalid-envvar-default:139:0:139:44::builtins.dict.get default type is builtins.list. Expected str or None.:UNDEFINED
61-
invalid-envvar-default:140:0:140:61::builtins.dict.get default type is builtins.list. Expected str or None.:UNDEFINED
62-
invalid-envvar-default:143:0:143:62::builtins.dict.get default type is builtins.bytes. Expected str or None.:UNDEFINED
63-
invalid-envvar-default:144:0:144:62::builtins.dict.get default type is builtins.bytes. Expected str or None.:UNDEFINED
32+
invalid-envvar-value:89:0:89:23::os.environ.get does not support builtins.bytes type argument:UNDEFINED
33+
invalid-envvar-value:91:0:91:20::os.environ.get does not support builtins.NoneType type argument:UNDEFINED
34+
invalid-envvar-value:92:0:92:24::os.environ.get does not support builtins.list type argument:UNDEFINED
35+
invalid-envvar-value:93:0:93:42::os.environ.get does not support builtins.bytes type argument:UNDEFINED
36+
invalid-envvar-value:94:0:94:47::os.environ.get does not support builtins.bytes type argument:UNDEFINED
37+
invalid-envvar-value:95:0:95:41::os.environ.get does not support builtins.list type argument:UNDEFINED
38+
invalid-envvar-value:96:0:96:41::os.environ.get does not support builtins.NoneType type argument:UNDEFINED
39+
invalid-envvar-value:100:0:100:34::os.environ.get does not support builtins.bytes type argument:UNDEFINED
40+
invalid-envvar-value:102:0:102:31::os.environ.get does not support builtins.NoneType type argument:UNDEFINED
41+
invalid-envvar-value:103:0:103:35::os.environ.get does not support builtins.list type argument:UNDEFINED
42+
invalid-envvar-value:104:0:104:53::os.environ.get does not support builtins.bytes type argument:UNDEFINED
43+
invalid-envvar-value:105:0:105:52::os.environ.get does not support builtins.list type argument:UNDEFINED
44+
invalid-envvar-value:106:0:106:52::os.environ.get does not support builtins.NoneType type argument:UNDEFINED
45+
invalid-envvar-value:109:0:109:27::os.environ.get does not support builtins.bytes type argument:UNDEFINED
46+
invalid-envvar-value:111:0:111:24::os.environ.get does not support builtins.NoneType type argument:UNDEFINED
47+
invalid-envvar-value:112:0:112:28::os.environ.get does not support builtins.list type argument:UNDEFINED
48+
invalid-envvar-value:113:0:113:46::os.environ.get does not support builtins.bytes type argument:UNDEFINED
49+
invalid-envvar-value:114:0:114:45::os.environ.get does not support builtins.list type argument:UNDEFINED
50+
invalid-envvar-value:115:0:115:45::os.environ.get does not support builtins.NoneType type argument:UNDEFINED
51+
invalid-envvar-default:119:0:119:26::os.environ.get default type is builtins.list. Expected str or None.:UNDEFINED
52+
invalid-envvar-default:121:0:121:30::os.environ.get default type is builtins.bytes. Expected str or None.:UNDEFINED
53+
invalid-envvar-default:122:0:122:49::os.environ.get default type is builtins.list. Expected str or None.:UNDEFINED
54+
invalid-envvar-default:125:0:125:50::os.environ.get default type is builtins.bytes. Expected str or None.:UNDEFINED
55+
invalid-envvar-default:128:0:128:34::os.environ.get default type is builtins.list. Expected str or None.:UNDEFINED
56+
invalid-envvar-default:130:0:130:38::os.environ.get default type is builtins.bytes. Expected str or None.:UNDEFINED
57+
invalid-envvar-default:131:0:131:57::os.environ.get default type is builtins.list. Expected str or None.:UNDEFINED
58+
invalid-envvar-default:134:0:134:58::os.environ.get default type is builtins.bytes. Expected str or None.:UNDEFINED
59+
invalid-envvar-default:138:0:138:44::os.environ.get default type is builtins.bytes. Expected str or None.:UNDEFINED
60+
invalid-envvar-default:139:0:139:44::os.environ.get default type is builtins.list. Expected str or None.:UNDEFINED
61+
invalid-envvar-default:140:0:140:61::os.environ.get default type is builtins.list. Expected str or None.:UNDEFINED
62+
invalid-envvar-default:143:0:143:62::os.environ.get default type is builtins.bytes. Expected str or None.:UNDEFINED
63+
invalid-envvar-default:144:0:144:62::os.environ.get default type is builtins.bytes. Expected str or None.:UNDEFINED

0 commit comments

Comments
 (0)