Code review

Author: cdce8p

doc/user_guide/checkers/features.rst

@@ -694,7 +694,7 @@ Match Statements checker Messages
 :multiple-class-sub-patterns (E1904): *Multiple sub-patterns for attribute %s*
   Emitted when there is more than one sub-pattern for a specific attribute in
   a class pattern.
-:match-class-bind-self (R1905): *Use '%s' instead*
+:match-class-bind-self (R1905): *Use '%s() as %s' instead*
   Match class patterns are faster if the name binding happens for the whole
   pattern and any lookup for `__match_args__` can be avoided.
 :match-class-positional-attributes (R1906): *Use keyword attributes instead of positional ones*

pylint/checkers/match_statements_checker.py

@@ -64,7 +64,7 @@ class MatchStatementChecker(BaseChecker):
             "attribute in a class pattern.",
         ),
         "R1905": (
-            "Use '%s' instead",
+            "Use '%s() as %s' instead",
             "match-class-bind-self",
             "Match class patterns are faster if the name binding happens "
             "for the whole pattern and any lookup for `__match_args__` "
@@ -132,7 +132,7 @@ def visit_matchas(self, node: nodes.MatchAs) -> None:
                     self.add_message(
                         "match-class-bind-self",
                         node=node,
-                        args=(f"{cls_name.name}() as {name}",),
+                        args=(cls_name.name, name),
                         confidence=HIGH,
                     )
 
@@ -197,7 +197,7 @@ def visit_matchclass(self, node: nodes.MatchClass) -> None:
                     self.add_message(
                         "match-class-positional-attributes",
                         node=node,
-                        confidence=HIGH,
+                        confidence=INFERENCE,
                     )
 
         if (

tests/functional/m/match_class_pattern.txt

@@ -9,5 +9,5 @@ multiple-class-sub-patterns:49:13:49:29:f2:Multiple sub-patterns for attribute x
 undefined-variable:55:13:55:23:f2:Undefined variable 'NotDefined':UNDEFINED
 match-class-bind-self:60:17:60:18:f3:Use 'int() as y' instead:HIGH
 match-class-bind-self:63:17:63:18:f3:Use 'str() as y' instead:HIGH
-match-class-positional-attributes:75:13:75:17:f4:Use keyword attributes instead of positional ones:HIGH
-match-class-positional-attributes:77:13:77:20:f4:Use keyword attributes instead of positional ones:HIGH
+match-class-positional-attributes:75:13:75:17:f4:Use keyword attributes instead of positional ones:INFERENCE
+match-class-positional-attributes:77:13:77:20:f4:Use keyword attributes instead of positional ones:INFERENCE