[fix] AttributeError crash when a slice is used as a class decorator (#10350) (#10361)

Co-authored-by: codegen-sh[bot] <131295404+codegen-sh[bot]@users.noreply.github.com>
Co-authored-by: Marc Mueller <[email protected]>

Author: 3 people

doc/whatsnew/fragments/10334.bugfix

@@ -0,0 +1,3 @@
+Using a slice as a class decorator now raise a 'not-callable' message instead of crashing pylint. A lot of checks that dealt with decorators (too many to list) are now shortcut if the decorator can't immediately be inferred to a function or class definition.
+
+Closes #10334

pylint/checkers/deprecated.py

@@ -136,7 +136,9 @@ def visit_decorators(self, node: nodes.Decorators) -> None:
             inf = safe_infer(children[0].func)
         else:
             inf = safe_infer(children[0])
-        qname = inf.qname() if inf else None
+        if not isinstance(inf, (nodes.ClassDef, nodes.FunctionDef)):
+            return
+        qname = inf.qname()
         if qname in self.deprecated_decorators():
             self.add_message("deprecated-decorator", node=node, args=qname)
 

pylint/checkers/utils.py

@@ -876,7 +876,7 @@ def decorated_with(
             if any(
                 i.name in qnames or i.qname() in qnames
                 for i in decorator_node.infer()
-                if i is not None and not isinstance(i, util.UninferableBase)
+                if isinstance(i, (nodes.ClassDef, nodes.FunctionDef))
             ):
                 return True
         except astroid.InferenceError:

tests/functional/r/regression_02/regression_10334.py

@@ -0,0 +1,6 @@
+"""Test for slice object used as a decorator."""
+# pylint: disable=too-few-public-methods
+s = slice(-2)
+@s()  # [not-callable]
+class A:
+    """Class with a slice decorator."""

tests/functional/r/regression_02/regression_10334.txt

@@ -0,0 +1 @@
+not-callable:4:1:4:4:A:s is not callable:UNDEFINED