Skip to content

warnings from internal use of apply_ufunc #4385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mathause opened this issue Aug 28, 2020 · 4 comments · Fixed by #4391
Closed

warnings from internal use of apply_ufunc #4385

mathause opened this issue Aug 28, 2020 · 4 comments · Fixed by #4391

Comments

@mathause
Copy link
Collaborator

Another follow up from #4060: quantile now emits a FutureWarning:

Minimal Complete Verifiable Example:

xr.DataArray([1, 2, 3]).quantile(q=0.5)
~/.conda/envs/ipcc_ar6/lib/python3.7/site-packages/xarray/core/variable.py:1866:
FutureWarning: ``output_sizes`` should be given in the ``dask_gufunc_kwargs``
parameter. It will be removed as direct parameter in a future version.
kwargs={"q": q, "axis": axis, "interpolation": interpolation},

We should probably check the warnings in the test suite - there may be others.

@kmuehlbauer
Copy link
Contributor

@mathause Then these internal uses should be adapted to the new use of apply_ufunc, right? As I feel somehow committed to #4060 I could work on this.

@dcherian
Copy link
Contributor

Then these internal uses should be adapted to the new use of apply_ufunc, right?

👍

I could work on this.

Only if you have time! No need to feel obligated :) but it should be relatively simple.

@kmuehlbauer
Copy link
Contributor

@dcherian Thanks, I'll come up with a PR over the weekend. But this should not block others to take over if this becomes urgent.

@mathause
Copy link
Collaborator Author

No worry this is only on master and not in a released version.

kmuehlbauer added a commit to kmuehlbauer/xarray that referenced this issue Aug 30, 2020
dcherian pushed a commit that referenced this issue Aug 30, 2020
#4391)

* move kwarg's `output_sizes` and `meta` to `dask_gufunc_kwargs` for internal use of `apply_ufunc` (follow-up to #4060, fixes #4385)

* add pull request referenz to `whats-new.rst`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants