Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sourcelink element broken in version 0.16.1 #2129

Closed
ukukas opened this issue Feb 10, 2025 · 2 comments
Closed

sourcelink element broken in version 0.16.1 #2129

ukukas opened this issue Feb 10, 2025 · 2 comments
Labels
kind: duplicate There is already another issue for this item.

Comments

@ukukas
Copy link

ukukas commented Feb 10, 2025

In version 0.16.1 the sourcelink element gets rendered as follows:

<div class="sidebar-secondary-item">
  <div role="note" aria-label="source link">
    <h3>This Page</h3>
    <ul class="this-page-menu">
      <li><a href="../_sources/index.md.txt" rel="nofollow">Show Source</a></li>
    </ul>
   </div>
</div>

Image

Reverting back to version 0.16.0 appears to fix the issue:

<div class="sidebar-secondary-item">
  <div class="tocsection sourcelink">
    <a href="../_sources/index.md.txt">
      <svg class="svg-inline--fa fa-file-lines" aria-hidden="true" focusable="false" data-prefix="fas" data-icon="file-lines" role="img" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 384 512" data-fa-i2svg=""><path fill="currentColor" d="M64 0C28.7 0 0 28.7 0 64V448c0 35.3 28.7 64 64 64H320c35.3 0 64-28.7 64-64V160H256c-17.7 0-32-14.3-32-32V0H64zM256 0V128H384L256 0zM112 256H272c8.8 0 16 7.2 16 16s-7.2 16-16 16H112c-8.8 0-16-7.2-16-16s7.2-16 16-16zm0 64H272c8.8 0 16 7.2 16 16s-7.2 16-16 16H112c-8.8 0-16-7.2-16-16s7.2-16 16-16zm0 64H272c8.8 0 16 7.2 16 16s-7.2 16-16 16H112c-8.8 0-16-7.2-16-16s7.2-16 16-16z"></path></svg><!-- <i class="fa-solid fa-file-lines"></i> Font Awesome fontawesome.com --> Show Source
    </a>
  </div>
</div>

Image

I do not see any changes to components/sourcelink.html so unsure what could be causing this.

The behavior remains the same when the sourcelink element is moved to the header or footer.

@trallard
Copy link
Collaborator

Hi there @ukukas do you have a link to your project?

I just checked our documentation and I can see the source links properly rendered, for example for https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/index.html

<a href="../_sources/user_guide/index.md">
      <svg class="svg-inline--fa fa-file-lines" aria-hidden="true" focusable="false" data-prefix="fas" data-icon="file-lines" role="img" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 384 512" data-fa-i2svg=""><path fill="currentColor" d="M64 0C28.7 0 0 28.7 0 64V448c0 35.3 28.7 64 64 64H320c35.3 0 64-28.7 64-64V160H256c-17.7 0-32-14.3-32-32V0H64zM256 0V128H384L256 0zM112 256H272c8.8 0 16 7.2 16 16s-7.2 16-16 16H112c-8.8 0-16-7.2-16-16s7.2-16 16-16zm0 64H272c8.8 0 16 7.2 16 16s-7.2 16-16 16H112c-8.8 0-16-7.2-16-16s7.2-16 16-16zm0 64H272c8.8 0 16 7.2 16 16s-7.2 16-16 16H112c-8.8 0-16-7.2-16-16s7.2-16 16-16z"></path></svg><!-- <i class="fa-solid fa-file-lines"></i> Font Awesome fontawesome.com --> Show Source
    </a>

@trallard trallard added needs: investigation Someone in the team needs to investigate and try and reproduce this issue needs: more information Needs more information from the author before we can move forward kind: duplicate There is already another issue for this item. and removed needs: more information Needs more information from the author before we can move forward needs: investigation Someone in the team needs to investigate and try and reproduce this issue labels Feb 11, 2025
@trallard
Copy link
Collaborator

Actually, this is a duplicate of #2088 so I am closing this as a duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: duplicate There is already another issue for this item.
Projects
None yet
Development

No branches or pull requests

2 participants