Skip to content

Commit 1ec4635

Browse files
Scope the Draft cancellation to pull requests the workflow runs for
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 7787388 commit 1ec4635

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

‎.github/workflows/test.yaml‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,9 @@ name: Test
1010
on:
1111
pull_request:
1212
# ready_for_review starts the AWS jobs for a pull request leaving Draft;
13-
# converted_to_draft starts a run without them, which cancels any
14-
# in-progress run through the concurrency group.
13+
# converted_to_draft starts a run without them, which cancels an
14+
# in-progress run through the concurrency group. paths-ignore applies to
15+
# both, so a pull request that now changes only docs starts neither.
1516
types: [opened, synchronize, reopened, ready_for_review, converted_to_draft]
1617
paths-ignore:
1718
- 'docs/**'

‎docs/testing.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ It runs the offline checks (`just lint`) on each of them, including Drafts and e
160160
For the compliance suites, the related files are `pyathena/sqlalchemy/`, `pyathena/aio/sqlalchemy/`, `tests/sqlalchemy/`, and `setup.cfg`.
161161
For the Spark tests, they are `pyathena/spark/`, `pyathena/aio/spark/`, `tests/pyathena/spark/`, and `tests/pyathena/aio/spark/`.
162162
Changes to `pyproject.toml`, `uv.lock`, `justfile`, or the Test workflows run both.
163-
Marking a Draft pull request ready for review starts its AWS jobs, and converting it back to Draft cancels them.
163+
For these pull requests, marking a Draft ready for review starts the AWS jobs, and converting it back to Draft cancels AWS jobs still running.
164164
To run every suite on a branch, dispatch the workflow:
165165

166166
```bash

0 commit comments

Comments
 (0)