Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: when a user adds a link to their github repo #74

Open
lwasser opened this issue Nov 2, 2023 · 3 comments
Open

BUG: when a user adds a link to their github repo #74

lwasser opened this issue Nov 2, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@lwasser
Copy link
Member

lwasser commented Nov 2, 2023

In the astartes review the links are provided via markdown as is the version.

Because of that when the link to the github url is parsed, it returns GitHub (which is the text) instead of the actual link.
We may need to add a check to the validator for links to ensure a link always begins with http and also to parse text if it is in markdown form.

Screen Shot 2023-11-02 at 8 50 49 AM

because version is parsed this way as well it might make sense to do a markdown link check helper method and runs on any code that is supposed to be a link.

see pyOpenSci/pyopensci.github.io#283 for what the manual fix looks like. if we run the action again however it will revert to the github text.

@lwasser lwasser added the bug Something isn't working label Nov 2, 2023
@cmarmo
Copy link
Member

cmarmo commented Nov 2, 2023

I was planning to edit the description of pyOpenSci/software-submission#120 after seeing pyOpenSci/pyopensci.github.io#283.
Is that ok or should I keep the current version as a test?

@lwasser
Copy link
Member Author

lwasser commented Nov 2, 2023

@cmarmo if you can fix the issue please do. thank you!

i will still leave this bug report open - but can then work on it when i have time rather than worrying about our next update!

@cmarmo
Copy link
Member

cmarmo commented Nov 2, 2023

if you can fix the issue please do. thank you!

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants