Improve the editor's load plots #43
Conversation
Fix the import of the `count_edits_by_quarter` function: now it's being imported from the `pyosmeta` package. Use purple color for the bars in the chart.
Use list comprehension to creating the `editors` list and removing the ignored ones at the time of creation. Remove the unnecessary check for ignored editors in the charts for loop.
Avoid the need to set the time and number of edits domains to set the same scale for every chart by using the `resolve_scale` method.
|
Thank you for this, @santisoler!!! I will pause my current pr #44 to make sure I don't interfere with your work again 🙈 . I'm trying to reorganize this repo to make space for our annual report and to add a page on contributor data. I haven't touched this notebook, however, so it should be easy enough to merge. Please just let me know when you'd like me to review it again. I think I'll undo moving this notebook in that pr to ensure we can merge both, and then I'll implement a final pr that moves everything around for the website! |
|
Hi @lwasser! Don't worry about me. Please, keep working on #44. I don't think I'll have too many problems updating this branch. Besides, I don't want your PR to be stalled because of mine. I plan to work on the notebook only, so as long as you don't expect to make a lot of changes to it, it should be fine. |
|
Okay, that's wonderful. @santisoler, yes, I don't plan to change the notebook you are working on. I'm working on a contributor notebook and reorganized the repo for a cleaner repository structure matching the website version. I appreciate your patience!! 🙌🏻 I only saw your new pr when I opened mine. Thank you again for your work here!! |
|
@santisoler i made two tiny changes to the current-reviews-data notebook to make CI happy. You can make them here in your branch and overwrite the main as you wish, as there are no code changes on main.
Please feel free to completely overwrite main with this pr if you rebase / or copy over !! As i made no real code changes - just fixes to make CI happy. ✨ no rush at all on this i just wanted you to know so it's not a surprise when you see a conflict here. |
Apply changes suggested in #24.