Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

countGoImportsScanned no longer reports the correct count #7

Open
pwaller opened this issue Feb 15, 2017 · 0 comments
Open

countGoImportsScanned no longer reports the correct count #7

pwaller opened this issue Feb 15, 2017 · 0 comments

Comments

@pwaller
Copy link
Owner

pwaller commented Feb 15, 2017

goimports got faster! 🎉

Unfortunately, in the process countGoImportsScanned doesn't work anymore, since goimports no longer prints the directories which are scanned when it is running in verbose mode. If we wanted to count this we'd have to count the syscalls (unportable) or reintroduce the message or add a counting feature to goimports itself. I guess it was removed for a reason.

The log message always shows 0 here now:

Ignored 434 directories. goimports considers 0 directories in 148ms (cpu=416ms).

I'm not actively working on this. I would accept a patch just to remove the count message, for now, at which point I would consider the issue closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant