New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong HostOptions typings #193

Open

ken-kuro opened this issue Jul 4, 2023 · 1 comment · May be fixed by #194

ken-kuro commented Jul 4, 2023

It's no big deal, but I think the port field of interface HostOptions in index.d.ts should be type number instead of string.

interface HostOptions extends BaseOptions {
    host: string
    port?: string
  }

ken-kuro linked a pull request

that will close this issue

fix: HostOptions typings #194

Open

4 tasks

shawnpetros commented Oct 11, 2024

also mentioned in docs that host is optional (defaults to api.pusherapp.com), but marked required here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment