Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated /apps/*/channels/*/events API call #205

Open
jameshfisher opened this issue Mar 3, 2016 · 2 comments
Open

Remove deprecated /apps/*/channels/*/events API call #205

jameshfisher opened this issue Mar 3, 2016 · 2 comments

Comments

@jameshfisher
Copy link
Contributor

I noticed this library is using a deprecated resource in the Pusher API: https://pusher.com/docs/rest_api_deprecated#method-post-event

Here's where it uses that resource: https://github.com/lukeredpath/libPusher/blob/f64d469fa80d8203598924ee35bad88b83261959/Library/PTPusherAPI.m#L37

It should be updated to use this resource: https://pusher.com/docs/rest_api#method-post-event

@lukeredpath
Copy link
Contributor

Thanks. I'm still considering whether to keep PTPusherAPI in the library to be honest. It has dependencies on some stuff I'd like to get rid of and is only a wrapper around a single API call I'm wondering if it has any value. Especially given how easy it is to trigger events over the socket-based API which is what this library should really be focussed on IMO.

@hamchapman what do you think?

@hamchapman
Copy link
Contributor

Yeah I'd be tempted to remove it. Keeping libPusher focussed on the socket-based API is a good move in my books

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants