Skip to content

a new mirror for testing #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thautwarm opened this issue Mar 1, 2020 · 6 comments
Open

a new mirror for testing #2

thautwarm opened this issue Mar 1, 2020 · 6 comments

Comments

@thautwarm
Copy link
Member

Currently, purescript-python will automatically download this repo(called mirror) for mapping a purescript library to a git repo for providing Python FFI.

However, with only one mirror, we cannot test adding new FFI repos, because changes of this mirror could affect the regular use.

For this perspective I'd suggest adding a new dedicated mirror for testing.

@vanceism7 Also, you can just push the changes to master branch of unregistered FFI provider repos like

@vanceism7
Copy link

vanceism7 commented Mar 1, 2020

Actually, I was able to test the new ffi providers i created by altering my local copy of the mirror located in the ~/.pspy directory. This might not be ideal but it worked pretty well for testing purposes

Also, you can just push the changes to master branch of unregistered FFI provider repos

Ok thanks will do!

@vanceism7
Copy link

Just throwing ideas around here - You might make a dedicated command for adding mirrors locally,
e.g: pspy mirror add-test "functions" "github-url"

And another for resetting the mirror back to the officially downloaded one:
pspy mirror reset

Not that this has to happen in the pspy binary, it could have it's own dedicated for this purpose as well

@thautwarm
Copy link
Member Author

thautwarm commented Mar 3, 2020

Hi, just passed the deadline.

Your idea is very close to what in my blueprint, I totally agree with your design.

The reason why we might not immediately implement this is, we shall consider working better with spago.
Isn't it better if spago can do this for us? I believe this is actually a spago thing.

See purescript/spago#434

@vanceism7
Copy link

Ohh gotcha, that makes sense. I guess we should be waiting on that before making a decision on how to handle this issue

@thautwarm
Copy link
Member Author

It depends. If people including you and me feel very annoying about it, we can just implement what you want.

@thautwarm
Copy link
Member Author

@vanceism7 things got pushed by my recent activities, that we have a chance to promote our project in China's python community. hence I choose to support this immediately.
see https://github.com/thautwarm/pspy-ffi-index-test#test-mirrorfor-purescript-python-developers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants