-
Notifications
You must be signed in to change notification settings - Fork 1
Statistics Tracking #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #75 +/- ##
==========================================
- Coverage 86.69% 86.23% -0.46%
==========================================
Files 8 8
Lines 2533 2609 +76
Branches 2533 2609 +76
==========================================
+ Hits 2196 2250 +54
- Misses 296 317 +21
- Partials 41 42 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Test Results46 tests 46 ✅ 1s ⏱️ Results for commit 93d5271. ♻️ This comment has been updated with latest results. |
b0b2e08 to
876fb25
Compare
969ee51 to
93638aa
Compare
Gitignore the webring.log Implement clearing the statistics data daily
876fb25 to
feb6f0c
Compare
e1614e8 to
93d5271
Compare
|
Why not export metrics in OTel or Prometheus format so we can integrate with dashboards? |
|
I don't know anything about either of those; could you point me to what I should read? |
Both are systems for collecting/processing metrics from software. Prometheus: https://prometheus.io/docs/introduction/overview/ OpenTelemetry (intro): https://opentelemetry.io/docs/what-is-opentelemetry/ Originally the plan was to add Prometheus metrics to collect standard performance/behavior metrics about the process, but it sounded like you wanted to collect other statistics (more like user behavior) so I left that up to you. We did also discuss Prometheus a little in Discord: https://discord.com/channels/772576325897945119/1319140464812753009/1373470039478370385 Basically it boils down to a standard format for exporting metrics so we can use existing software to collect/process/display the data instead of having to re-implement all of that. There are also application-side libraries for Prometheus (and I assume OTel too) that make it easy to calculate and export more complex metrics like histograms of response latencies. |
|
Ok sick, I will look into those, though I'm highkey locked in for spill so I may look at that over the winter |
Closes #50
MVP
Important but maybe a future PR