Create Stdlib::File::* types

Previously these were prefixed, but this creates an explicit namespace.

Author: ekohl

spec/type_aliases/file_mode_spec.rb

@@ -0,0 +1,61 @@
+# coding: utf-8
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'Stdlib::File::Mode' do
+  describe 'valid modes' do
+    [
+      '7',
+      '12',
+      '666',
+
+      '0000',
+      '0644',
+      '1644',
+      '2644',
+      '4644',
+      '0123',
+      '0777',
+
+      'a=,o-r,u+X,g=w',
+      'a=Xr,+0',
+      'u=rwx,g+rX',
+      'u+s,g-s',
+    ].each do |value|
+      describe value.inspect do
+        it { is_expected.to allow_value(value) }
+      end
+    end
+  end
+
+  describe 'invalid modes' do
+    context 'with garbage inputs' do
+      [
+        true,
+        false,
+        :keyword,
+        nil,
+        [nil],
+        [nil, nil],
+        { 'foo' => 'bar' },
+        {},
+        '',
+        "\n0644",
+        "\n0644\n",
+        "0644\n",
+        'ネット',
+        '55555',
+        '0x123',
+        '0649',
+
+        '=8,X',
+        'x=r,a=wx',
+      ].each do |value|
+        describe value.inspect do
+          it { is_expected.not_to allow_value(value) }
+        end
+      end
+    end
+  end
+end

spec/type_aliases/file_source_spec.rb

@@ -0,0 +1,64 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'Stdlib::File::Source' do
+  describe 'valid handling' do
+    [
+      'https://hello.com',
+      'https://notcreative.org',
+      'https://canstillaccepthttps.co.uk',
+      'http://anhttp.com',
+      'http://runningoutofideas.gov',
+      'file:///hello/bla',
+      'file:///foo/bar.log',
+      'puppet:///modules/foo/bar.log',
+      'puppet://pm.example.com/modules/foo/bar.log',
+      'puppet://192.0.2.1/modules/foo/bar.log',
+      '/usr2/username/bin:/usr/local/bin:/usr/bin:.',
+      'C:/',
+      'C:\\',
+      'C:\\WINDOWS\\System32',
+      'C:/windows/system32',
+      'X:/foo/bar',
+      'X:\\foo\\bar',
+      '\\\\host\\windows',
+      '//host/windows',
+      '/var/tmp',
+      '/var/opt/../lib/puppet',
+      'puppet:///a_custom_mount_point/foo/bar/foobar.conf',
+    ].each do |value|
+      describe value.inspect do
+        it { is_expected.to allow_value(value) }
+      end
+    end
+  end
+
+  describe 'invalid path handling' do
+    context 'garbage inputs' do
+      [
+        nil,
+        [nil],
+        [nil, nil],
+        { 'foo' => 'bar' },
+        {},
+        '',
+        "\nfile:///foo/bar.log",
+        "\nfile:///foo/bar.log\n",
+        "file:///foo/bar.log\n",
+        "\npuppet:///modules/foo/bar.log",
+        "\npuppet:///modules/foo/bar.log\n",
+        "puppet:///modules/foo/bar.log\n",
+        '*/Users//nope',
+        '\\Users/hc/wksp/stdlib',
+        'C:noslashes',
+        '\\var\\tmp',
+        'puppet://[email protected]/modules/foo/bar.log',
+      ].each do |value|
+        describe value.inspect do
+          it { is_expected.not_to allow_value(value) }
+        end
+      end
+    end
+  end
+end

types/file/mode.pp

@@ -0,0 +1,5 @@
+# @summary Validate a file mode
+# See `man chmod.1` for the regular expression for symbolic mode
+# lint:ignore:140chars
+type Stdlib::File::Mode = Pattern[/\A(([0-7]{1,4})|(([ugoa]*([-+=]([rwxXst]*|[ugo]))+|[-+=][0-7]+)(,([ugoa]*([-+=]([rwxXst]*|[ugo]))+|[-+=][0-7]+))*))\z/]
+# lint:endignore

types/file/source.pp

@@ -0,0 +1,9 @@
+# @summary Validate the source parameter on file types
+type Stdlib::File::Source = Variant[
+  Stdlib::Absolutepath,
+  Stdlib::HTTPUrl,
+  Pattern[
+    /\Afile:\/\/\/([^\n\/\0]+(\/)?)+\z/,
+    /\Apuppet:\/\/(([\w-]+\.?)+)?\/([^\n\/\0]+(\/)?)+\z/,
+  ],
+]

types/filemode.pp

@@ -1,5 +1,3 @@
 # @summary Validate a file mode
-# See `man chmod.1` for the regular expression for symbolic mode
-# lint:ignore:140chars
-type Stdlib::Filemode = Pattern[/\A(([0-7]{1,4})|(([ugoa]*([-+=]([rwxXst]*|[ugo]))+|[-+=][0-7]+)(,([ugoa]*([-+=]([rwxXst]*|[ugo]))+|[-+=][0-7]+))*))\z/]
-# lint:endignore
+# @deprecated Use Stdlib::File::Mode
+type Stdlib::Filemode = Stdlib::File::Mode

types/filesource.pp

@@ -1,9 +1,3 @@
 # @summary Validate the source parameter on file types
-type Stdlib::Filesource = Variant[
-  Stdlib::Absolutepath,
-  Stdlib::HTTPUrl,
-  Pattern[
-    /\Afile:\/\/\/([^\n\/\0]+(\/)?)+\z/,
-    /\Apuppet:\/\/(([\w-]+\.?)+)?\/([^\n\/\0]+(\/)?)+\z/,
-  ],
-]
+# @deprecated Use Stdlib::File::Source
+type Stdlib::Filesource = Stdlib::File::Source