Skip to content

poolmetadatasize parameter appears to have invalid type set #327

Open
@eringet

Description

@eringet

Describe the Bug

I believe the poolmetadatasize parameter should be allowed to be a string such as '10M'
If it must be an integer and not a string, the rspec test should be updated.
Our own rspec tests fail if we set the poolmetadatasize, with
'parameter 'poolmetadatasize' expects a value of type Undef or Integer, got String'

Expected Behavior

Parameter documentation, rspec tests and parameter types are consistent.

Steps to Reproduce

poolmetadatasize parameter is set to be an integer:
https://github.com/puppetlabs/puppetlabs-lvm/blob/v2.1.0/manifests/logical_volume.pp#L77

but in rspec test, a poolmetadatasize of '10M' is used:
https://github.com/puppetlabs/puppetlabs-lvm/blob/v2.1.0/spec/unit/puppet/type/logical_volume_spec.rb#L18

Environment

  • Version 2.1.0
  • Platform RHEL 8

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions