Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker_stack incorrectly determines if the stack is deployed #968

Open
gerases opened this issue Feb 7, 2024 · 1 comment
Open

docker_stack incorrectly determines if the stack is deployed #968

gerases opened this issue Feb 7, 2024 · 1 comment
Labels

Comments

@gerases
Copy link

gerases commented Feb 7, 2024

Describe the Bug

When a stack runs on several machines and the services are spread out between them, this check in docker/lib/puppet/provider/docker_stack/ruby.rb doesn't work correctly:

      if stack_services.count != stack_containers.count
        return false
      end

Expected Behavior

Containers belonging to the same stack but running on other machines should be taken into account.

Additional Context

This code exists in version 4 of the module but also in the current version. I'm prepared to learn that I'm using the stack resource incorrectly for some reason.

@gerases gerases added the bug label Feb 7, 2024
@akremer
Copy link

akremer commented Mar 25, 2024

Can confirm this bug exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants