Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no working parameter combination for docker 1.x and root_dir #942

Open
Enrice opened this issue Jul 31, 2023 · 0 comments
Open

no working parameter combination for docker 1.x and root_dir #942

Enrice opened this issue Jul 31, 2023 · 0 comments
Labels

Comments

@Enrice
Copy link

Enrice commented Jul 31, 2023

If using the legacy distribution provided docker yum packages (1.13.1) there is no working combination of the following parameters due to wrong regexes in

if ($version == undef) or ($version !~ /^(17[.][0-1][0-9][.][0-1](~|-|\.)ce|1.\d+)/) {

and
if ($version != undef) and ($version =~ /^(17[.]0[0-4]|1.\d+)/) {

  • version (specify or leave empty)
  • root_dir (I need that)
  • use_upstream_package_source => false (as documented in the README)
  • service_overrides_template => false (as documented in the README)
  • docker_ce_package_name => 'docker' (as documented in the README)

Actual Problem

If version is specified, all docker_ce_* parameters are ignored.
If version is not specified, the root_dir_flag will be '--data-root', which does not yet exist in 1.13.1.

Environment

  • any module version, but used latest 9.1.0
  • CentOS 7

Some thoughts

The regexes trying to cover 1.x are wrong anyway:
1.\d+
matches ANY character after 1, which is not intended...
And what about versions 0.x?

I would come up with the following for 0.x and 1.x:
[01][.]\d+[.]\d
which also addresses semver conformity.

@Enrice Enrice added the bug label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant