(GH-724) PDK New Module with Native Window Picker

This commit updates the PDK New Module command to use the native window picker instead of asking the user to enter in the fully qualified path. It also opens the newly created module inside the window the command was issued in, instead of opening a new VS Code window.

By using the native window picker, we get the correct experience on WIndows, Mac and Linxu. Even inside WSL or even Remote Containers.

Author: jpogran

src/feature/PDKFeature.ts

@@ -1,5 +1,5 @@
-'use strict';
-
+import * as fs from 'fs';
+import * as path from 'path';
 import * as vscode from 'vscode';
 import { IFeature } from '../feature';
 import { ILogger } from '../logging';
@@ -76,31 +76,52 @@ export class PDKFeature implements IFeature {
     this.terminal.dispose();
   }
 
-  private pdkNewModuleCommand(): void {
-    const nameOpts: vscode.QuickPickOptions = {
-      placeHolder: 'Enter a name for the new Puppet module',
-      matchOnDescription: true,
-      matchOnDetail: true,
-    };
-    const dirOpts: vscode.QuickPickOptions = {
-      placeHolder: 'Enter a path for the new Puppet module',
-      matchOnDescription: true,
-      matchOnDetail: true,
-    };
+  private async pdkNewModuleCommand(): Promise<void> {
+    const name = await vscode.window.showInputBox({
+      prompt: 'Enter a name for the new Puppet module',
+    });
+    if (name === undefined) {
+      vscode.window.showWarningMessage('No module name specifed. Exiting.');
+      return;
+    }
+    const directory = await vscode.window.showOpenDialog({
+      canSelectMany: false,
+      canSelectFiles: false,
+      canSelectFolders: true,
+      openLabel: 'Choose the path for the new Puppet module',
+    });
+    if (directory === undefined) {
+      vscode.window.showWarningMessage('No directory specifed. Exiting.');
+      return;
+    }
+
+    const p = path.join(directory[0].fsPath, name);
+
+    this.terminal.sendText(`pdk new module --skip-interview ${name} ${p}`);
+    this.terminal.show();
 
-    vscode.window.showInputBox(nameOpts).then((moduleName) => {
-      if (moduleName === undefined) {
-        vscode.window.showWarningMessage('No module name specifed. Exiting.');
-        return;
-      }
-      vscode.window.showInputBox(dirOpts).then((dir) => {
-        this.terminal.sendText(`pdk new module --skip-interview ${moduleName} ${dir}`);
-        this.terminal.sendText(`code ${dir}`);
-        this.terminal.show();
-        if (reporter) {
-          reporter.sendTelemetryEvent(PDKCommandStrings.PdkNewModuleCommandId);
+    await new Promise<void>((resolve) => {
+      let count = 0;
+      const handle = setInterval(() => {
+        count++;
+        if (count >= 30) {
+          clearInterval(handle);
+          resolve();
+          return;
         }
-      });
+
+        if (fs.existsSync(p)) {
+          resolve();
+          return;
+        }
+      }, 1000);
     });
+
+    const uri = vscode.Uri.file(p);
+    await vscode.commands.executeCommand('vscode.openFolder', uri);
+
+    if (reporter) {
+      reporter.sendTelemetryEvent(PDKCommandStrings.PdkNewModuleCommandId);
+    }
   }
 }