Skip to content

Commit 12b4712

Browse files
Merge pull request #106 from justinstoller/timeout-errors
(PE-39731) Log request info on failure or cancellation
2 parents 89dc1ce + 898ccc0 commit 12b4712

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/java/com/puppetlabs/http/client/impl/JavaClient.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -344,6 +344,7 @@ private static void completeResponse(ResponseDeliveryDelegate responseDeliveryDe
344344
contentType,
345345
callback);
346346
} catch (Exception e) {
347+
LOGGER.error("Processing successful request to {} raised '{}'", requestOptions.getUri().toString(), e.getMessage());
347348
responseDeliveryDelegate.deliverResponse(requestOptions, e, callback);
348349
}
349350
}
@@ -479,11 +480,13 @@ public void completed(HttpResponse httpResponse) {
479480

480481
@Override
481482
public void failed(Exception e) {
483+
LOGGER.error("{} request to '{}' failed.", method.toString(), requestOptions.getUri().toString());
482484
responseDeliveryDelegate.deliverResponse(requestOptions, e, callback);
483485
}
484486

485487
@Override
486488
public void cancelled() {
489+
LOGGER.error("{} request to '{}' cancelled.", method.toString(), requestOptions.getUri().toString());
487490
responseDeliveryDelegate.deliverResponse(requestOptions,
488491
new HttpClientException("Request cancelled"),
489492
callback);

0 commit comments

Comments
 (0)