Skip to content

Commit a9874e1

Browse files
committed
review comments
1 parent 5ec9ec0 commit a9874e1

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

content/blog/esc-connect/index.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@ values:
3333
secretName: DATABASE_PASSWORD
3434
```
3535
36-
When you open this environment, ESC makes an authenticated POST request to your adapter.
37-
Your adapter validates the JWT token, fetches the secret from your source, and returns it:
36+
When you open this environment, ESC makes an authenticated POST request to your adapter. Your adapter validates the JWT token, fetches the secret from your source, and returns it:
3837
3938
```typescript
4039
const handler = async (event) => {
@@ -58,7 +57,7 @@ The [example reference implementation](#try-it-out) includes an `ESCRequestValid
5857

5958
## Automated rotation
6059

61-
ESC Connect also supports automated secret rotation through [`fn::rotate::external`](/docs/esc/integrations/rotated-secrets/external/). Your rotation adapter receives the current credential state, generates new credentials, updates your target system, and returns the new state. ESC handles scheduling and maintains both current and previous credentials during transitions for zero-downtime rotation.
60+
ESC Connect also supports automated secret rotation through `fn::rotate::external`. Your rotation adapter receives the current credential state, generates new credentials, updates your target system, and returns the new state. ESC handles scheduling and maintains both current and previous credentials during rotation transitions for zero-downtime rotation.
6261

6362
```yaml
6463
values:

content/docs/esc/integrations/dynamic-secrets/external.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ The external provider serves as a generic escape hatch for integrating secret so
2727

2828
Use the external provider when:
2929

30-
- You need to integrate a custom or proprietary secret management system
31-
- You have specific business logic for secret fetching
32-
- Your secret source is behind a firewall or requires custom networking
30+
- You need to integrate a custom or proprietary secret management system.
31+
- You have specific business logic for secret fetching.
32+
- Your secret source is behind a firewall or requires custom networking.
3333

3434
## ESC Configuration Example
3535

@@ -154,7 +154,7 @@ import jwt
154154
from jwt import PyJWKClient
155155
156156
# Configuration
157-
JWKS_URL = "https://api.pulumi.com/.well-known/jwks.json"
157+
JWKS_URL = "https://api.pulumi.com/oidc/.well-known/jwks"
158158
ADAPTER_URL = "https://my-adapter.example.com/fetch-secrets"
159159
PORT = 8443
160160

content/docs/esc/integrations/rotated-secrets/external.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,9 @@ After rotation, applications see only the current secret:
207207

208208
Your application should always use `apiCredentials.current`. After rotation, `current` contains the newly rotated secret, while the previous secret remains valid until the next rotation.
209209

210-
**Important:** Configure your rotation schedule to be less frequent than your application's configuration refresh interval. For example, if your app fetches configuration every 5 minutes, rotate no more than once per hour.
210+
{{% notes type="warning" %}}
211+
Configure your rotation schedule to be less frequent than your application's configuration refresh interval. For example, if your app fetches configuration every 5 minutes, rotate no more than once per hour.
212+
{{% /notes %}}
211213

212214
### Example Rotator Implementation
213215

0 commit comments

Comments
 (0)