Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore workdir with try finally for immediate tasks #6293

Closed
mdellweg opened this issue Feb 24, 2025 · 0 comments · Fixed by #6294
Closed

Restore workdir with try finally for immediate tasks #6293

mdellweg opened this issue Feb 24, 2025 · 0 comments · Fixed by #6294

Comments

@mdellweg
Copy link
Member 

          If the task failed, this code path will not be executed. I think, we need to put this in a try finally block.

Originally posted by @mdellweg in #6292 (comment)
git-hyagi added a commit to git-hyagi/pulpcore that referenced this issue Feb 24, 2025
@git-hyagi
Change workdir even if the immediate task fails
e4f93b5 
fixes: pulp#6293
@git-hyagi git-hyagi mentioned this issue Feb 24, 2025
Merged
mdellweg pushed a commit that referenced this issue Feb 24, 2025
@git-hyagi @mdellweg
Change workdir even if the immediate task fails
703333d 
fixes: #6293
git-hyagi added a commit to git-hyagi/pulpcore that referenced this issue Feb 24, 2025
@git-hyagi
Change workdir even if the immediate task fails
d1ce27f 
fixes: pulp#6293
(cherry picked from commit 703333d)
@git-hyagi git-hyagi mentioned this issue Feb 24, 2025
Merged
mdellweg pushed a commit that referenced this issue Feb 24, 2025
@git-hyagi @mdellweg
Change workdir even if the immediate task fails
7f7ad47 
fixes: #6293
(cherry picked from commit 703333d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change workdir even if the immediate task fails git-hyagi/pulpcore
1 participant
@mdellweg