Fix / revert fetch TypeError handling (#415)

fix(subscribe): fix / revert `fetch` `TypeError` handling

Revert fix created to handle browser timeouts (not gracefully). The Web Fetch API doesn't have
descriptive error information, and it sends `TypeError` for both cases when connection closed
by browser or network issue (blocked domain).

Author: parfeon

.pubnub.yml

@@ -1,5 +1,10 @@
 ---
 changelog:
+  - date: 2024-10-25
+    version: v8.2.9
+    changes:
+      - type: bug
+        text: "Revert fix created to handle browser timeouts (not gracefully). The Web Fetch API doesn't have descriptive error information, and it sends `TypeError` for both cases when connection closed by browser or network issue (blocked domain)."
   - date: 2024-09-30
     version: v8.2.8
     changes:
@@ -1036,7 +1041,7 @@ supported-platforms:
       - 'Ubuntu 14.04 and up'
       - 'Windows 7 and up'
     version: 'Pubnub Javascript for Node'
-version: '8.2.8'
+version: '8.2.9'
 sdks:
   - full-name: PubNub Javascript SDK
     short-name: Javascript
@@ -1052,7 +1057,7 @@ sdks:
           - distribution-type: source
             distribution-repository: GitHub release
             package-name: pubnub.js
-            location: https://github.com/pubnub/javascript/archive/refs/tags/v8.2.8.zip
+            location: https://github.com/pubnub/javascript/archive/refs/tags/v8.2.9.zip
             requires:
               - name: 'agentkeepalive'
                 min-version: '3.5.2'
@@ -1723,7 +1728,7 @@ sdks:
           - distribution-type: library
             distribution-repository: GitHub release
             package-name: pubnub.js
-            location: https://github.com/pubnub/javascript/releases/download/v8.2.8/pubnub.8.2.8.js
+            location: https://github.com/pubnub/javascript/releases/download/v8.2.9/pubnub.8.2.9.js
             requires:
               - name: 'agentkeepalive'
                 min-version: '3.5.2'

CHANGELOG.md

@@ -1,3 +1,9 @@
+## v8.2.9
+October 25 2024
+
+#### Fixed
+- Revert fix created to handle browser timeouts (not gracefully). The Web Fetch API doesn't have descriptive error information, and it sends `TypeError` for both cases when connection closed by browser or network issue (blocked domain).
+
 ## v8.2.8
 September 30 2024
 

README.md

@@ -28,8 +28,8 @@ Watch [Getting Started with PubNub JS SDK](https://app.dashcam.io/replay/64ee0d2
      npm install pubnub
      ```
    * or download one of our builds from our CDN: 
-     * https://cdn.pubnub.com/sdk/javascript/pubnub.8.2.8.js
-     * https://cdn.pubnub.com/sdk/javascript/pubnub.8.2.8.min.js
+     * https://cdn.pubnub.com/sdk/javascript/pubnub.8.2.9.js
+     * https://cdn.pubnub.com/sdk/javascript/pubnub.8.2.9.min.js
 
 2. Configure your keys:
 

dist/web/pubnub.js

@@ -2839,10 +2839,7 @@
 	            message = 'Network issues';
 	        }
 	        else if (errorName === 'TypeError') {
-	            if (message.indexOf('Load failed') !== -1 || message.indexOf('Failed to fetch') != -1)
-	                category = StatusCategory$1.PNTimeoutCategory;
-	            else
-	                category = StatusCategory$1.PNBadRequestCategory;
+	            category = StatusCategory$1.PNBadRequestCategory;
 	        }
 	        else if (errorName === 'FetchError') {
 	            const errorCode = error.code;
@@ -3816,7 +3813,7 @@
 	            return base.PubNubFile;
 	        },
 	        get version() {
-	            return '8.2.8';
+	            return '8.2.9';
 	        },
 	        getVersion() {
 	            return this.version;

dist/web/pubnub.min.js

@@ -110,7 +110,7 @@ const makeConfiguration = (base, setupCryptoModule) => {
             return base.PubNubFile;
         },
         get version() {
-            return '8.2.8';
+            return '8.2.9';
         },
         getVersion() {
             return this.version;

lib/core/components/configuration.js

@@ -62,10 +62,7 @@ class PubNubAPIError extends Error {
             message = 'Network issues';
         }
         else if (errorName === 'TypeError') {
-            if (message.indexOf('Load failed') !== -1 || message.indexOf('Failed to fetch') != -1)
-                category = categories_1.default.PNTimeoutCategory;
-            else
-                category = categories_1.default.PNBadRequestCategory;
+            category = categories_1.default.PNBadRequestCategory;
         }
         else if (errorName === 'FetchError') {
             const errorCode = error.code;

lib/errors/pubnub-api-error.js

@@ -1,6 +1,6 @@
 {
   "name": "pubnub",
-  "version": "8.2.8",
+  "version": "8.2.9",
   "author": "PubNub <[email protected]>",
   "description": "Publish & Subscribe Real-time Messaging with PubNub",
   "scripts": {

package.json

@@ -169,7 +169,7 @@ export const makeConfiguration = (
       return base.PubNubFile;
     },
     get version(): string {
-      return '8.2.8';
+      return '8.2.9';
     },
     getVersion(): string {
       return this.version;

src/core/components/configuration.ts

@@ -58,9 +58,7 @@ export class PubNubAPIError extends Error {
       category = StatusCategory.PNNetworkIssuesCategory;
       message = 'Network issues';
     } else if (errorName === 'TypeError') {
-      if (message.indexOf('Load failed') !== -1 || message.indexOf('Failed to fetch') != -1)
-        category = StatusCategory.PNTimeoutCategory;
-      else category = StatusCategory.PNBadRequestCategory;
+      category = StatusCategory.PNBadRequestCategory;
     } else if (errorName === 'FetchError') {
       const errorCode = (error as Record<string, string>).code;