Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop setting to increase capture image resolution above currently fixed 640px #893

Open
cesswairimu opened this issue Feb 25, 2022 · 1 comment

Comments

@cesswairimu
Copy link
Contributor

No description provided.

@jywarren
Copy link
Member

I want to say, i think that the new WebRTC library that was installed can now request different resolutions. So I think this may be a little simpler, but in addition to that there will still need to be the ability to change the pixel size of the canvas we're working on.

First, here is some existing code to change the resolution. I don't know if it works?

https://github.com/publiclab/spectral-workbench.js/blob/6b658483535b5f1585163be01dfdf07961351a76/examples/capture/getUserMedia.js#L43-L54

Ah, it looks like this was implemented in publiclab/spectral-workbench.js#173 for the old interface!

So I wonder, is our task:

  • put a "resolution" dropdown in the new interface like in this code change
  • check if it works - and check if code like $W.updateResolution("720p") works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants