Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Callback bei ErrorList #7310

Open
deleonio opened this issue Jan 24, 2025 · 0 comments · Fixed by #7331 or #7359
Open

Feature Callback bei ErrorList #7310

deleonio opened this issue Jan 24, 2025 · 0 comments · Fixed by #7331 or #7359
Assignees
@deleonio
Labels
feature New feature or request Form good first issue Good for newcomers v2 v3 Here are issues that need to be resolved for version 3.

Comments

@deleonio
Copy link
Contributor

Bei Fehlerlisten, die über mehrere Tabs geht, funktioniert der reine Selektor nicht.

Es wäre gut, dass wir hier auch einen Callback anbieten:

kolibri/packages/components/src/schema/props/error-list.ts

Line 7 in 186a6ab

selector: string;

@deleonio deleonio moved this to 🗂️ Backlog in KoliBri Board Jan 24, 2025
@deleonio deleonio added good first issue Good for newcomers Form labels Jan 24, 2025
@deleonio deleonio moved this from 🗂️ Backlog to 📄 Ready in KoliBri Board Jan 28, 2025
@deleonio deleonio added feature New feature or request v2 v3 Here are issues that need to be resolved for version 3. labels Jan 28, 2025
@deleonio deleonio self-assigned this Jan 29, 2025
@deleonio deleonio removed the status in KoliBri Board Jan 29, 2025
@deleonio deleonio moved this to 🏗 In progress in KoliBri Board Jan 29, 2025
deleonio added a commit that referenced this issue Jan 29, 2025
@deleonio
Refactor error list handling: improve link click behavior and enhance…
7bc4b64 
… scrolling functionality

Refs: #7310
@deleonio deleonio mentioned this issue Jan 29, 2025
Merged
5 tasks
deleonio added a commit that referenced this issue Jan 29, 2025
@deleonio
Refactor error list handling: improve link click behavior and enhance…
b53e745 
… scrolling functionality

Refs: #7310
publicuibot bot pushed a commit that referenced this issue Jan 29, 2025
@deleonio @publicuibot
Update all snapshots$
f9b1ca9 
$
Refs: #7310
deleonio added a commit that referenced this issue Jan 29, 2025
@deleonio
Enhance error list functionality: improve scrolling and focus behavio…
2b6505b 
…r for error links

Refs: #7310
@deleonio deleonio mentioned this issue Jan 29, 2025
Merged
5 tasks
@deleonio deleonio linked a pull request Jan 29, 2025 that will close this issue
Enhance error list functionality: improve scrolling and focus behavio… #7331
Merged
5 tasks
deleonio added a commit that referenced this issue Jan 29, 2025
@deleonio
Fix formRef initialization to handle null value in FormErrorList comp…
426ac02 
…onent

Refs: #7310
deleonio added a commit that referenced this issue Jan 29, 2025
@deleonio
Fix formRef initialization: set initial value to null for proper type…
68f3151 
… handling

Refs: #7310
@deleonio deleonio mentioned this issue Jan 29, 2025
Merged
deleonio added a commit that referenced this issue Jan 29, 2025
@deleonio
Fix duplicate import of 'h' in shadow.tsx component
f7a825b 
Refs: #7310
publicuibot bot pushed a commit that referenced this issue Jan 30, 2025
@deleonio @publicuibot
Update all snapshots$
f20d662 
$
Refs: #7310
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in KoliBri Board Jan 30, 2025
sdvg added a commit that referenced this issue Feb 3, 2025
@sdvg
Merge branch 'develop' of github.com:public-ui/kolibri into 6176-toas…
57b268d 
…t-dialog

* 'develop' of github.com:public-ui/kolibri: (1915 commits)
  Fix concurrency group syntax in dod-checker workflow
  Remove auto file generator workflow
  remove some prepack scripts
  Update all snapshots$ $ Refs: #7310
  Fix duplicate import of 'h' in shadow.tsx component
  Fix formRef initialization to handle null value in FormErrorList component
  Enhance error list functionality: improve scrolling and focus behavior for error links
  Enhance error list rendering: add smooth scroll and focus behavior for alert component
  Update all snapshots$ $ Refs: #6645
  update kolibri deps and lock
  Update all snapshots$ $ Refs: #7178
  Extend input fields aria-described property to all types of messages, not just errors
  Unify JSDoc property descriptions
  Fix table double layers and hyphens
  Fix Drawer controlled mode: Allow to open with an initial _open property
  Update all snapshots$ $ Refs: #7178
  KolInputRange: Fix width calculation for number input
  Update all snapshots$ $ Refs: #6645
  Fix icon line-height for edge cases
  Increase contrast for card box-shadow
  ...
sdvg added a commit that referenced this issue Feb 4, 2025
@sdvg
Merge branch 'develop' of github.com:public-ui/kolibri into 7155-depr…
af9dddd 
…ecate-themes-v3

* 'develop' of github.com:public-ui/kolibri:
  Update all snapshots$ $ Refs: #5844
  chore: release 3.0.0-rc.3
  Fix concurrency group syntax in dod-checker workflow
  Remove auto file generator workflow
  remove some prepack scripts
  Update all snapshots$ $ Refs: #7310
  Fix duplicate import of 'h' in shadow.tsx component
  Fix formRef initialization to handle null value in FormErrorList component
  Enhance error list functionality: improve scrolling and focus behavior for error links
  Enhance error list rendering: add smooth scroll and focus behavior for alert component
  Fix test
  Update all snapshots$ $ Refs: #5844
  set initial focus to slot area
  Refactor modal and add snapshots tests
  Update all snapshots$ $ Refs: #5844
  Fix lint error
  Fix imports
  Add styles, e2e tests and update sample app
  Add close button for modal
@deleonio deleonio reopened this Feb 5, 2025
@github-project-automation github-project-automation bot moved this from ✅ Done to 🏗 In progress in KoliBri Board Feb 5, 2025
@deleonio deleonio linked a pull request Feb 5, 2025 that will close this issue
refactor: remove auto scrollToErrorList call #7359
Merged
5 tasks
@deleonio deleonio linked a pull request Feb 5, 2025 that will close this issue
refactor: remove auto scrollToErrorList call #7357
Closed
5 tasks
publicuibot bot pushed a commit that referenced this issue Feb 5, 2025
@deleonio @publicuibot
Update all snapshots$
da924c8 
$
Refs: #7310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deleonio deleonio

Labels
feature New feature or request Form good first issue Good for newcomers v2 v3 Here are issues that need to be resolved for version 3.
Projects
KoliBri Board
Status: 🏗 In progress
Milestone
No milestone
1 participant
@deleonio