Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Comments #2422

Closed
Coronon opened this issue Aug 11, 2021 · 2 comments
Closed

Better Comments #2422

Coronon opened this issue Aug 11, 2021 · 2 comments
Labels
F: comments The syntactic kind. Not in the language grammar, always on our minds. Best bugs. T: enhancement New feature or request

Comments

@Coronon
Copy link

Coronon commented Aug 11, 2021

Is your feature request related to a problem? Please describe.

I am using the VisualStudio Code extension Better Comments, which works by coloring comments based on a specific symbol/string right after the comment start. The frustrating part is that Black always adds a space in between, which would turn this:

a = 10  #? Should we change this

into this:

a = 10  # ? Should we change this

which looks disgraceful.

Describe the solution you'd like

Some setting for an array of characters that can extend the commen start e.g. `--comment-start '["*", "!", "TODO"]'

Describe alternatives you've considered

Another option would be a flag to turn of formatting a space after the comment start.

@Coronon Coronon added the T: enhancement New feature or request label Aug 11, 2021
@JelleZijlstra JelleZijlstra added the F: comments The syntactic kind. Not in the language grammar, always on our minds. Best bugs. label Aug 11, 2021
@CobaltCause
Copy link

I too would like an option to control this behavior, but probably more to just disable it entirely. I find that having the space is good for prose, but requiring it for disabled code feels wrong/unnecessary, and enforcing this automatically is probably not possible.

@JelleZijlstra
Copy link
Collaborator

Closing in favor of #3668.

@JelleZijlstra JelleZijlstra closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: comments The syntactic kind. Not in the language grammar, always on our minds. Best bugs. T: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants