Effects not working on Korvo2

[GFelipeSanchezS]

I have a device that sends musical notes over UDP and I then convert this on the Korvo to a frequency. Everything works well, except that the effects are not being applied for some reason. It just sounds like a plain sine wave. I tested the effects using keys instead and they work, but when I do my UDP port, no effects.

PS: I would love some guidance on synth a Trumpet sound as I am unable to make something anywhere similar.

#include <WiFi.h>
#include <WiFiUdp.h>
#include "AudioTools.h"
#include "AudioTools/AudioLibs/AudioBoardStream.h"

// Input Stream
AudioInfo info(32000, 2, 16);
SineWaveGenerator<int16_t> wave(32000);
GeneratedSoundStream<int16_t> in(wave);

// Tuning variables
float atk = 0.0015;
float dcy = 0.0101;
float stn = 0.8500;
float rls = 0.0002;
int   dur = 25;
int   dep = 20;
int   dst = 900;

AudioEffectStream effects(in);
ADSRGain adsr(atk, dcy, stn, rls);
Tremolo tremolo(dur, dep);
Distortion distortion(dst);

// Set up Board
DriverPins korvo_pins;
AudioBoard board(AudioDriverES8311, korvo_pins);
AudioBoardStream out(board);

// Output Stream
StreamCopy copier(out, in);

// UDP WiFi Set up
const char *ssid = "Server";
const char *password = "Pass";
WiFiUDP udp;
const int port = 50001;

uint16_t note_data = 0x0000;
uint16_t note_data_old = 0x0000;

double find_note(const uint16_t (uint16_t finger_data) {
  double freq = 440.0 * pow(2, -finger_data / 12.0);
  return freq;
}

void setup(void) {
  Serial.begin(115200);
  while (!Serial); // Wait for Serial Monitor to open
  Serial.println("\nStart");

  // Setup WiFI
  WiFi.begin(ssid, password);
  while (WiFi.status() != WL_CONNECTED) {
    delay(500);
    Serial.print(".");
  }
  Serial.println();
  Serial.print("Connected to WiFi.");
  // Print the IP address of the ESP32
  IPAddress ip = WiFi.localIP();
  Serial.print("ESP32 IP address: ");
  Serial.println(ip);
  // Bind the UDP socket to the port
  udp.begin(port);  
  
  // --- CONFIGURE PRIMARY I2C (Wire) FOR AUDIO CODEC ---
  korvo_pins.addI2C(audio_driver::PinFunction::CODEC, 18, 17);  // SCL = GPIO18, SDA = GPIO17
  korvo_pins.addI2S(audio_driver::PinFunction::CODEC, 16, 9, 45, 8, -1);
  korvo_pins.addPin(audio_driver::PinFunction::PA, 48, audio_driver::PinLogic::Output);
  korvo_pins.begin();

  // --- START AUDIO OUTPUT ---
  Serial.println("starting I2S...");
  auto config = out.defaultConfig(TX_MODE);
  config.copyFrom(info);
  config.sd_active = false;
  out.begin(config);
  out.setVolume(0.75);

  // Add effects
  effects.addEffect(tremolo);
  effects.addEffect(distortion);
  effects.addEffect(adsr);
  effects.begin(config);

  // Setup sine wave
  wave.begin(info, N_C4);
  Serial.println("started...");
  pinMode(5, INPUT_PULLUP);
}

double audio_data_raw;

void loop() {
  int packetSize = udp.parsePacket();
  if (packetSize) {
    uint8_t buffer[packetSize];
    udp.read(buffer, packetSize);

    finger_data = (buffer[1] << 8) | buffer[0];
  }

  if (finger_data_old != finger_data) {
    adsr.keyOff();
    finger_data_old = finger_data;
    audio_data_raw = find_note(finger_data);
    wave.setFrequency(audio_data_raw);

    adsr.keyOn();
  }
  
  Serial.print(WiFi.localIP());
  copier.copy();
}

[pschatzmann]

I suggest that you use the following chain: GeneratedSoundStream -copy-> AudioEffectStream -> AudioBoardStream
so you need to change

AudioEffectStream effects(out);
StreamCopy copier(effects, in);

The following would also work GeneratedSoundStream --> AudioEffectStream -copy> AudioBoardStream

AudioEffectStream effects(in);
StreamCopy copier(out, effects);

The STK library has some instruments...

[GFelipeSanchezS]

Oh, I am silly, I was testing direct in to out bypassing effects and sent you that code instead of the one with the problem. I actually tried originally with:

AudioEffectStream effects(in);
StreamCopy copier(out, effects);

but the effects were not working that way. However, this seems to be working:

AudioEffectStream effects(out);
StreamCopy copier(effects, in);

Also, I did not use the STK because it does not sound like brass and the higher frequencies are too distorted. Any suggestions are appreciated

[GFelipeSanchezS]

A Trumpet goes from 164.81Hz to 1396.91Hz, and the Brass STK has a range of 262.64Hz to 880Hz. Anything outside that range does not make more than a clicking sound. Any suggestion to make this trumpet synth?

[pschatzmann]

You could try if decreasing the sample rate helps: you could go down to 8000 and still be able to output that frequency range!
Another approach would be to play back some recorded trumpet sound and base your processing on this.