Skip to content

Inconsistency between the spec and implementation. #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
butterunderflow opened this issue Nov 22, 2022 · 2 comments
Closed

Inconsistency between the spec and implementation. #36

butterunderflow opened this issue Nov 22, 2022 · 2 comments

Comments

@butterunderflow
Copy link

Hello, I'm a newcomer to proxy-wasm.

It seems there has been some inconsistency between the spec and implementation.
For example, the host interface proxy_get_map_value is not used in Go SDK nor Rust SDK, they use proxy_get_header_map_value instead. For example.

Is this intentional or is it a choice of implementations?

@codefromthecrypt
Copy link

ran into another one today: proxy_send_http_response here, but proxy_send_local_response in the impls. For example, https://github.com/proxy-wasm/proxy-wasm-cpp-host/blob/d32cb05cb666216db5e1a383c1ffa2c1aeec19bb/include/proxy-wasm/wasm_api_impl.h#L98

@mathetake
Copy link
Contributor

I am closing this issue, but please refer to #39 (comment) for the context!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants