build: compile with C++20 (#441)

* build using c++20

std=c++20 is used by both v8 and Envoy. Switching to use it is necessary to build with more recent versions of v8, and will also reduce overall build surprises when importing proxy-wasm-cpp-host into Envoy.

Signed-off-by: Michael Warres <[email protected]>

* change --config=clang-asan-strict to --config=clang-asan

Signed-off-by: Michael Warres <[email protected]>

* chore: support clang-18 and ubuntu-24.04

These changes make Proxy-Wasm build cleanly with clang-18 and pass clang-tidy-18 checks.

Signed-off-by: Matt Leon <[email protected]>

* chore: ignore c++20 + clang-18 + gcc-14 findings

Signed-off-by: Matt Leon <[email protected]>

---------

Signed-off-by: Michael Warres <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Co-authored-by: Michael Warres <[email protected]>

Author: leonm1

.bazelrc

@@ -10,6 +10,7 @@ build --action_env=PATH
 build:clang --action_env=BAZEL_COMPILER=clang
 build:clang --action_env=CC=clang
 build:clang --action_env=CXX=clang++
+build:clang --copt -Wno-pragma-once-outside-header --cxxopt -Wno-pragma-once-outside-header
 
 # Common flags for Clang sanitizers.
 build:clang-xsan --config=clang
@@ -80,10 +81,10 @@ build:zig-cc-linux-aarch64 --test_env=QEMU_LD_PREFIX=/usr/aarch64-linux-gnu/
 
 build --enable_platform_specific_config
 
-# Use C++17.
-build:linux --cxxopt=-std=c++17
-build:macos --cxxopt=-std=c++17
-build:windows --cxxopt="/std:c++17"
+# Use C++20.
+build:linux --cxxopt=-std=c++20 --host_cxxopt=-std=c++20
+build:macos --cxxopt=-std=c++20 --host_cxxopt=-std=c++20
+build:windows --cxxopt="/std:c++20" --host_cxxopt="/std:c++20"
 
 # Enable symlinks and runfiles on Windows (enabled by default on other platforms).
 startup --windows_enable_symlinks

.clang-tidy

@@ -1,23 +1,38 @@
 Checks:            clang-*,
+                   -clang-analyzer-core.CallAndMessage,
                    -clang-analyzer-optin.portability.UnixAPI,
                    -clang-analyzer-unix.Malloc,
                    -clang-diagnostic-pragma-once-outside-header,
+                   -clang-diagnostic-builtin-macro-redefined,
                    cppcoreguidelines-pro-type-member-init,
                    cppcoreguidelines-pro-type-static-cast-downcast,
                    misc-*,
                    -misc-non-private-member-variables-in-classes,
+                   -misc-use-anonymous-namespace,
+                   -misc-const-correctness,
+                   -misc-include-cleaner,
+                   -misc-unused-parameters,
                    modernize-*,
                    -modernize-avoid-c-arrays,
                    -modernize-use-trailing-return-type,
+                   -modernize-return-braced-init-list,
+                   -modernize-use-default-member-init,
+                   -modernize-type-traits,
+                   -modernize-use-emplace,
                    llvm-include-order,
                    performance-*,
                    -performance-no-int-to-ptr,
+                   -performance-avoid-endl,
                    portability-*,
                    readability-*,
                    -readability-convert-member-functions-to-static,
                    -readability-function-cognitive-complexity,
                    -readability-magic-numbers,
                    -readability-make-member-function-const,
                    -readability-simplify-boolean-expr,
+                   -readability-identifier-length,
+                   -readability-container-data-pointer,
+                   -readability-redundant-casting,
+                   -readability-avoid-return-with-void-value,
 
 WarningsAsErrors:  '*'

.github/workflows/format.yml

@@ -43,7 +43,7 @@ jobs:
   addlicense:
     name: verify licenses
 
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
 
     steps:
     - uses: actions/checkout@v2
@@ -63,7 +63,7 @@ jobs:
   buildifier:
     name: check format with buildifier
 
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
 
     steps:
     - uses: actions/checkout@v2
@@ -101,29 +101,29 @@ jobs:
   clang_format:
     name: check format with clang-format
 
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
 
     steps:
     - uses: actions/checkout@v2
 
     - name: Install dependencies (Linux)
-      run: sudo apt update -y && sudo apt install -y clang-format-12
+      run: sudo apt update -y && sudo apt install -y clang-format-18
 
     - name: Format (clang-format)
       run: |
-        find . -name "*.h" -o -name "*.cc" -o -name "*.proto" | grep -v ".pb." | xargs -n1 clang-format-12 -i
+        find . -name "*.h" -o -name "*.cc" -o -name "*.proto" | grep -v ".pb." | xargs -n1 clang-format-18 -i
         git diff --exit-code
 
   clang_tidy:
     name: check format with clang-tidy
 
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
 
     steps:
     - uses: actions/checkout@v2
 
     - name: Install dependencies (Linux)
-      run: sudo apt update -y && sudo apt install -y clang-tidy-12 lld-12 && sudo ln -sf /usr/bin/lld-12 /usr/bin/lld
+      run: sudo apt update -y && sudo apt install -y clang-tidy-18 lld-18 && sudo ln -sf /usr/bin/lld-18 /usr/bin/lld
 
     - name: Bazel cache
       uses: PiotrSikora/[email protected]

.github/workflows/test.yml

@@ -43,7 +43,7 @@ jobs:
   test_data:
     name: build test data
 
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
 
     steps:
     - uses: actions/checkout@v2
@@ -111,19 +111,19 @@ jobs:
         include:
         - name: 'NullVM on Linux/x86_64'
           engine: 'null'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
           flags: --config=gcc
         - name: 'NullVM on Linux/x86_64 with ASan'
           engine: 'null'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
-          flags: --config=clang-asan-strict --define=crypto=system
+          flags: --config=clang-asan --define=crypto=system
         - name: 'NullVM on Linux/x86_64 with TSan'
           engine: 'null'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
           flags: --config=clang-tsan
@@ -136,39 +136,39 @@ jobs:
         - name: 'V8 on Linux/x86_64'
           engine: 'v8'
           repo: 'v8'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
           flags: --config=clang --define=crypto=system
           cache: true
         - name: 'V8 on Linux/x86_64 with ASan'
           engine: 'v8'
           repo: 'v8'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
           flags: --config=clang-asan
           cache: true
         - name: 'V8 on Linux/x86_64 with TSan'
           engine: 'v8'
           repo: 'v8'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
           flags: --config=clang-tsan
           cache: true
         - name: 'V8 on Linux/x86_64 with GCC'
           engine: 'v8'
           repo: 'v8'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
           flags: --config=gcc
           cache: true
         - name: 'V8 on Linux/aarch64'
           engine: 'v8'
           repo: 'v8'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: aarch64
           action: test
           targets: -//test/fuzz/...
@@ -185,7 +185,7 @@ jobs:
         - name: 'WAMR interp on Linux/x86_64'
           engine: 'wamr-interp'
           repo: 'com_github_bytecodealliance_wasm_micro_runtime'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
           flags: --config=clang
@@ -198,11 +198,11 @@ jobs:
         - name: 'WAMR jit on Linux/x86_64'
           engine: 'wamr-jit'
           repo: 'com_github_bytecodealliance_wasm_micro_runtime'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
           flags: --config=clang
-          deps: lld-12
+          deps: lld-18
           cache: true
         - name: 'WAMR jit on macOS/x86_64'
           engine: 'wamr-jit'
@@ -214,7 +214,7 @@ jobs:
         - name: 'WasmEdge on Linux/x86_64'
           engine: 'wasmedge'
           repo: 'com_github_wasmedge_wasmedge'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
           flags: --config=clang
@@ -227,29 +227,29 @@ jobs:
         - name: 'Wasmtime on Linux/x86_64'
           engine: 'wasmtime'
           repo: 'com_github_bytecodealliance_wasmtime'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
           flags: --config=clang -c opt
         - name: 'Wasmtime on Linux/x86_64 with ASan'
           engine: 'wasmtime'
           repo: 'com_github_bytecodealliance_wasmtime'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: x86_64
           action: test
-          flags: --config=clang-asan-strict --define=crypto=system
+          flags: --config=clang-asan --define=crypto=system
         - name: 'Wasmtime on Linux/aarch64'
           engine: 'wasmtime'
           repo: 'com_github_bytecodealliance_wasmtime'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: aarch64
           action: build
           flags: --config=zig-cc-linux-aarch64
           deps: qemu-user-static libc6-arm64-cross
         - name: 'Wasmtime on Linux/s390x'
           engine: 'wasmtime'
           repo: 'com_github_bytecodealliance_wasmtime'
-          os: ubuntu-22.04
+          os: ubuntu-24.04
           arch: s390x
           action: test
           flags: --config=clang --test_timeout=1800

bazel/external/bazel_clang_tidy.patch

@@ -1,5 +1,4 @@
 # 1. Treat .h files as C++ headers.
-# 2. Hardcode clang-tidy-12.
 
 diff --git a/clang_tidy/clang_tidy.bzl b/clang_tidy/clang_tidy.bzl
 index 3a5ed07..5db5c6c 100644
@@ -15,13 +14,3 @@ index 3a5ed07..5db5c6c 100644
      # start args passed to the compiler
      args.add("--")
 
-diff --git a/clang_tidy/run_clang_tidy.sh b/clang_tidy/run_clang_tidy.sh
-index 582bab1..b9ebb94 100755
---- a/clang_tidy/run_clang_tidy.sh
-+++ b/clang_tidy/run_clang_tidy.sh
-@@ -11,4 +11,4 @@ shift
- touch $OUTPUT
- truncate -s 0 $OUTPUT
- 
--clang-tidy "$@"
-+clang-tidy-12 "$@"

bazel/external/v8.patch

@@ -20,11 +20,14 @@ diff --git a/bazel/defs.bzl b/bazel/defs.bzl
 index e957c0fad3..063627b72b 100644
 --- a/bazel/defs.bzl
 +++ b/bazel/defs.bzl
-@@ -131,6 +131,7 @@ def _default_args():
+@@ -131,6 +131,10 @@ def _default_args():
                  "-Wno-redundant-move",
                  "-Wno-return-type",
                  "-Wno-stringop-overflow",
 +                "-Wno-nonnull",
++                "-Wno-error=pessimizing-move",
++                "-Wno-error=dangling-reference",
++                "-Wno-error=dangling-pointer=",
                  # Use GNU dialect, because GCC doesn't allow using
                  # ##__VA_ARGS__ when in standards-conforming mode.
                  "-std=gnu++17",

bazel/external/wasmedge.BUILD

@@ -18,6 +18,9 @@ cmake(
         "WASMEDGE_BUILD_TOOLS": "Off",
         "WASMEDGE_FORCE_DISABLE_LTO": "On",
     },
+    env = {
+        "CXXFLAGS": "-Wno-error=dangling-reference -Wno-error=maybe-uninitialized -Wno-error=array-bounds= -Wno-error=deprecated-declarations -std=c++20",
+    },
     generate_args = ["-GNinja"],
     lib_source = ":srcs",
     out_static_libs = ["libwasmedge.a"],

bazel/repositories.bzl

@@ -130,9 +130,9 @@ def proxy_wasm_cpp_host_repositories():
     maybe(
         http_archive,
         name = "proxy_wasm_cpp_sdk",
-        sha256 = "89792fc1abca331f29f99870476a04146de5e82ff903bdffca90e6729c1f2470",
-        strip_prefix = "proxy-wasm-cpp-sdk-95bb82ce45c41d9100fd1ec15d2ffc67f7f3ceee",
-        urls = ["https://github.com/proxy-wasm/proxy-wasm-cpp-sdk/archive/95bb82ce45c41d9100fd1ec15d2ffc67f7f3ceee.tar.gz"],
+        sha256 = "26c4c0f9f645de7e789dc92f113d7352ee54ac43bb93ae3a8a22945f1ce71590",
+        strip_prefix = "proxy-wasm-cpp-sdk-7465dee8b2953beebff99f6dc3720ad0c79bab99",
+        urls = ["https://github.com/proxy-wasm/proxy-wasm-cpp-sdk/archive/7465dee8b2953beebff99f6dc3720ad0c79bab99.tar.gz"],
     )
 
     # Compile DB dependencies.
@@ -149,11 +149,9 @@ def proxy_wasm_cpp_host_repositories():
     maybe(
         http_archive,
         name = "com_google_googletest",
-        sha256 = "9dc9157a9a1551ec7a7e43daea9a694a0bb5fb8bec81235d8a1e6ef64c716dcb",
-        strip_prefix = "googletest-release-1.10.0",
-        urls = ["https://github.com/google/googletest/archive/release-1.10.0.tar.gz"],
-        patches = ["@proxy_wasm_cpp_host//bazel/external:googletest.patch"],
-        patch_args = ["-p1"],
+        sha256 = "65fab701d9829d38cb77c14acdc431d2108bfdbf8979e40eb8ae567edf10b27c",
+        strip_prefix = "googletest-1.17.0",
+        urls = ["https://github.com/google/googletest/releases/download/v1.17.0/googletest-1.17.0.tar.gz"],
     )
 
     # NullVM dependencies.

src/null/null_plugin.cc

@@ -26,7 +26,6 @@
 #include <utility>
 #include <vector>
 
-#include "include/proxy-wasm/null_plugin.h"
 #include "include/proxy-wasm/null_vm.h"
 #include "include/proxy-wasm/wasm.h"
 

src/wasmedge/wasmedge.cc

@@ -19,6 +19,7 @@
 
 #include "wasmedge/wasmedge.h"
 
+#include <algorithm>
 #include <array>
 #include <cassert>
 #include <cstring>