fix: revert ChangeType::Creation attributes without DB lookup#1072
Open
louise-poole wants to merge 1 commit into
Open
fix: revert ChangeType::Creation attributes without DB lookup#1072louise-poole wants to merge 1 commit into
louise-poole wants to merge 1 commit into
Conversation
Chain reorgs on Base crashed with "Could not find Component" when a partial block was reverted that contained an attribute first set with ChangeType::Creation (e.g. a new Uniswap V4 tick slot). These attributes have no prior state anywhere — not in the reorg buffer (reverted range) and not in the DB (non-finalized component) — so looking up their previous value is both impossible and unnecessary. Track ChangeType::Creation attributes in a new `created_attributes` field on ProtocolComponentStateDelta, populated during protobuf deserialisation. In handle_revert, filter these out of the buffer/DB lookup entirely and emit ChangeType::Deletion directly instead. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chain reorgs on Base crashed with "Could not find Component" when a partial block was reverted that contained an attribute first set with ChangeType::Creation (e.g. a new Uniswap V4 tick slot). These attributes have no prior state anywhere — not in the reorg buffer (reverted range) and not in the DB (non-finalized component) — so looking up their previous value is both impossible and unnecessary.
Track ChangeType::Creation attributes in a new
created_attributesfield on ProtocolComponentStateDelta, populated during protobuf deserialisation. In handle_revert, filter these out of the buffer/DB lookup entirely and emit ChangeType::Deletion directly instead.