New build system based on sh file, also version is substituted via env var

Author: proofrock

.github/workflows/main.yml

@@ -6,8 +6,9 @@ on:
       - "v*"
 
 env:
-  GO_VERSION: "1.23.5"
+  GO_VERSION: "1.24.2"
   REGISTRY_IMAGE: "ghcr.io/proofrock/ws4sql"
+  VERSION: ${{ github.ref_name }}
 
 jobs:
   test:
@@ -31,10 +32,6 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
 
-      - name: Modify version number
-        run: sed -i 's/v0\.0\.0/${{ github.ref_name }}/g' ws4sql.go
-        working-directory: src/
-
       - name: Build dir generation
         run: mkdir bin/
 
@@ -45,7 +42,7 @@ jobs:
 
       - name: Compile and Pack Artifact
         run: |
-          apk add --no-cache musl-dev go g++ git make openssl openssl-dev openssl-libs-static zstd
+          apk add --no-cache musl-dev go g++ git make openssl openssl-dev openssl-libs-static zstd bash
           make build-static-ci-linux-musl-amd64
           tar czf bin/ws4sql-${{ github.ref_name }}-linux-amd64.tar.gz -C bin/ ws4sql
         shell: alpine.sh --root {0}
@@ -64,10 +61,6 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
 
-      - name: Modify version number
-        run: sed -i 's/v0\.0\.0/${{ github.ref_name }}/g' ws4sql.go
-        working-directory: src/
-
       - name: Build dir generation
         run: mkdir bin/
 
@@ -79,7 +72,7 @@ jobs:
 
       - name: Compile and Pack Artifact
         run: |
-          apk add --no-cache musl-dev go g++ git make openssl openssl-dev openssl-libs-static zstd
+          apk add --no-cache musl-dev go g++ git make openssl openssl-dev openssl-libs-static zstd bash
           make build-static-ci-linux-musl-arm64
           tar czf bin/ws4sql-${{ github.ref_name }}-linux-arm64.tar.gz -C bin/ ws4sql
         shell: alpine.sh --root {0}
@@ -102,10 +95,6 @@ jobs:
         with:
           go-version: ${{ env.GO_VERSION }}
 
-      - name: Modify version number
-        run: sed -i.bkp 's/v0\.0\.0/${{ github.ref_name }}/g' ws4sql.go
-        working-directory: src/
-
       - name: Build dir generation
         run: mkdir bin/
 
@@ -133,10 +122,6 @@ jobs:
         with:
           go-version: ${{ env.GO_VERSION }}
 
-      - name: Modify version number
-        run: sed -i.bkp 's/v0\.0\.0/${{ github.ref_name }}/g' ws4sql.go
-        working-directory: src/
-
       - name: Build dir generation
         run: mkdir bin/
 
@@ -164,10 +149,6 @@ jobs:
         with:
           go-version: ${{ env.GO_VERSION }}
 
-      - name: Modify version number
-        run: sed -i 's/v0\.0\.0/${{ github.ref_name }}/g' ws4sql.go
-        working-directory: src/
-
       - name: Build dir generation
         run: mkdir bin/
 

Makefile

@@ -23,29 +23,27 @@ build-nostatic:
 
 build-static-linux:
 	make build-prepare
-	cd src; go build -trimpath -a -tags="netgo osusergo sqlite_omit_load_extension" -ldflags='-w -extldflags "-static"'
+	cd src; VERSION="v0.0.999" bash build.sh LINUX
 	mv src/ws4sql bin/
 
 build-static-windows:
 	make build-prepare
-	cd src; go build -trimpath -a -tags="netgo osusergo sqlite_omit_load_extension" -ldflags='-w -extldflags "-static"'
+	cd src; VERSION="v0.0.999" bash build.sh WIN
 	mv src/ws4sql.exe bin/
 
 build-static-macos:
 	make build-prepare
-	cd src; go build -trimpath -a -tags="netgo osusergo sqlite_omit_load_extension" -ldflags='-w'
+	cd src; VERSION="v0.0.999" bash build.sh MAC
 	mv src/ws4sql bin/
 
 # The following three targets are used in Github Actions
 # Can be also run in an Alpine Linux context with the following packages
-#   musl-dev go g++ make openssl openssl-dev openssl-libs-static zstd
+#   musl-dev go g++ make openssl openssl-dev openssl-libs-static zstd bash
 
 build-static-ci-common:
 	make build-prepare
-	cd src && zstd -d libduckdb_bundle.a.zst
-	cd src && CGO_CFLAGS="-O2 -fPIC" CGO_CXXFLAGS="-O2 -fPIC" CGO_LDFLAGS="-lduckdb_bundle -lssl -lcrypto -L./" go build -buildvcs=false -trimpath -a -tags="netgo osusergo sqlite_omit_load_extension duckdb_use_static_lib" -ldflags='-w -extldflags "-static"'
+	cd src && bash build.sh CI
 	mv src/ws4sql bin/
-	rm src/libduckdb_bundle.a
 
 build-static-ci-linux-musl-amd64:
 	cp precompiled/libduckdb_bundle/linux-musl-amd64/libduckdb_bundle.a.zst src/

src/build.sh

@@ -0,0 +1,41 @@
+#!/bin/bash
+
+# This script is used to build a binary
+
+# Copy inside the src/ dir
+# Env vars that must be already set: VERSION
+
+case $1 in
+    "MAC")
+        go build -trimpath -a -o ws4sql \
+            -tags="netgo osusergo sqlite_omit_load_extension" \
+            -ldflags="-w -buildid=\"$VERSION\" -X \"main.version=$VERSION\""
+        ;;
+    "LINUX")
+        go build -trimpath -a -o ws4sql \
+            -tags="netgo osusergo sqlite_omit_load_extension" \
+            -ldflags="-w -buildid=\"$VERSION\" -X \"main.version=$VERSION\" -extldflags \"-static\""
+        ;;
+    "WIN")
+        go build -trimpath -a -o ws4sql.exe \
+            -tags="netgo osusergo sqlite_omit_load_extension" \
+            -ldflags="-w -buildid=\"$VERSION\" -X \"main.version=$VERSION\" -extldflags \"-static\""
+        ;;
+    "CI" )
+        zstd -dk libduckdb_bundle.a.zst
+        # '-O3' gives a warning in sqlite
+        # Maybe -ldflags="buildid=\"$VERSION\" ..."
+        CGO_ENABLED=1 \
+        CPPFLAGS="-DDUCKDB_STATIC_BUILD" \
+        CGO_CFLAGS="-O2" CGO_CXXFLAGS="-O2" \
+        CGO_LDFLAGS="-static -lduckdb_bundle -lssl -lcrypto -lstdc++ -L." \
+        go build \
+          -buildvcs=false \
+          -trimpath \
+          -tags="netgo osusergo sqlite_omit_load_extension duckdb_use_static_lib" \
+          -ldflags="-X \"main.version=$VERSION\"" \
+          -o ws4sql
+        rm libduckdb_bundle.a
+        rm libduckdb_bundle.a.zst
+esac
+

src/ws4sql.go

@@ -38,7 +38,7 @@ import (
 	_ "github.com/mattn/go-sqlite3"
 )
 
-const version = "v0.0.0"
+var version string // Set at build time, var VERSION
 
 // Simply prints a header, parses the cli parameters and calls
 // launch(), that is the real entry point. It's separate from the