Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prombench: The go version in prometheus' .promu.yml is not respected #438

Open
roidelapluie opened this issue Sep 28, 2020 · 1 comment
Open

Comments

@roidelapluie
Copy link
Member

I have noticed that prombench for 2.18.0 did run with go 1.13 instead of go 1.14.

The version in .promu.yml was 1.14. We should respect that, so we can test against the relevant go versions.

@roidelapluie roidelapluie changed the title The version of .promu.yml is not respected The go version in .promu.yml is not respected Sep 28, 2020
@roidelapluie roidelapluie changed the title The go version in .promu.yml is not respected Prombench: The go version in proetheus' .promu.yml is not respected Sep 28, 2020
@roidelapluie roidelapluie changed the title Prombench: The go version in proetheus' .promu.yml is not respected Prombench: The go version in prometheus' .promu.yml is not respected Sep 28, 2020
@geekodour
Copy link
Member

I am a little confused about how it ran with 1.13 It should've ran with 1.15.

echo ">> Creating prometheus binaries"
if ! make build PROMU_BINARIES="prometheus"; then
echo "ERROR:: Building of binaries failed"
exit 1;
fi

But this is not a issue if we're comparing the issue against the docker image that is prebuilt because it then directly uses it. Building only occurs for the PR version of prometheus.

containers:
- name: prometheus
image: quay.io/prometheus/prometheus:{{ .RELEASE }}
imagePullPolicy: Always

Am I understanding this wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants