feat: expose Desc error through public Err() method (#1902)

* feat: expose Desc error through public Err() method

Adds a public Err() method to Desc type to allow users to check if
an error occurred during descriptor construction. Previously, the error
field was private and inaccessible.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Signed-off-by: Yuri Nikolic <[email protected]>

* Fixing review findings

Signed-off-by: Yuri Nikolic <[email protected]>

* Fixing failing test

Signed-off-by: Yuri Nikolic <[email protected]>

---------

Signed-off-by: Yuri Nikolic <[email protected]>
Co-authored-by: Claude <[email protected]>

Author: duricanikolic

prometheus/desc.go

@@ -182,6 +182,15 @@ func NewInvalidDesc(err error) *Desc {
 	}
 }
 
+// Err returns an error that occurred during construction, if any.
+//
+// Calling this method is optional. It can be used to detect construction
+// errors early, before invoking other methods on the Desc. If an error is
+// present, later operations may not behave as expected.
+func (d *Desc) Err() error {
+	return d.err
+}
+
 func (d *Desc) String() string {
 	lpStrings := make([]string, 0, len(d.constLabelPairs))
 	for _, lp := range d.constLabelPairs {

prometheus/desc_test.go

@@ -17,15 +17,29 @@ import (
 	"testing"
 )
 
-func TestNewDescInvalidLabelValues(t *testing.T) {
+func TestNewDescInvalidConstLabelValues(t *testing.T) {
+	labelValue := "\xFF"
 	desc := NewDesc(
 		"sample_label",
 		"sample label",
 		nil,
-		Labels{"a": "\xFF"},
+		Labels{"a": labelValue},
 	)
-	if desc.err == nil {
-		t.Errorf("NewDesc: expected error because: %s", desc.err)
+	if desc.Err() == nil {
+		t.Errorf("NewDesc: expected error because const label value is invalid: %s", labelValue)
+	}
+}
+
+func TestNewDescInvalidVariableLabelName(t *testing.T) {
+	labelValue := "__label__"
+	desc := NewDesc(
+		"sample_label",
+		"sample label",
+		[]string{labelValue},
+		Labels{"a": "b"},
+	)
+	if desc.Err() == nil {
+		t.Errorf("NewDesc: expected error because variable label name is invalid: %s", labelValue)
 	}
 }
 
@@ -36,8 +50,8 @@ func TestNewDescNilLabelValues(t *testing.T) {
 		nil,
 		nil,
 	)
-	if desc.err != nil {
-		t.Errorf("NewDesc: unexpected error: %s", desc.err)
+	if desc.Err() != nil {
+		t.Errorf("NewDesc: unexpected error: %s", desc.Err())
 	}
 }