-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add card feature to msteamsv2_config #4243
base: main
Are you sure you want to change the base?
Conversation
All checks have passed 🎉 , waiting for someone to merge this PR ⌚ |
I would really like to avoid pushing users towards templating JSON blobs. It has a lot of problems that I've explained in a couple other PRs such as #3799 (comment). I think supporting cards would be excellent, because visually its a massive improvement, but just not with templated JSON. |
Nevermind, I would have try. |
What if you made cards the default instead of a separate field, using the template you have already written? Visually it looks so much better in my opinion! |
Hello @grobinson-grafana ! I'm trying to add a card template in the I think that i've correctly defined the card template but it does not seem to detect it... Some help is needed |
Hi @jverger, did you rename your template function to Your card is more readable then the existing one, we need your template to be used as default one :) |
2978d90
to
df4fd79
Compare
Signed-off-by: jverger <[email protected]> Signed-off-by: Tossaporn Jiw <[email protected]>
Signed-off-by: jverger <[email protected]> Signed-off-by: Tossaporn Jiw <[email protected]>
Signed-off-by: Anastasios_Dados <[email protected]> Signed-off-by: Tossaporn Jiw <[email protected]>
…on (prometheus#4258) The update addresses failing GitHub Actions caused by the deprecation of v3 actions/upload-artifact and actions/download-artifact APIs. This change: - Updates promci from previous version to v0.4.6 - I hope resolves CI failures in artifact upload/download steps Signed-off-by: Raúl Naveiras <[email protected]> Signed-off-by: Tossaporn Jiw <[email protected]>
…on (prometheus#4259) Same as prometheus#4258 The update addresses failing GitHub Actions caused by the deprecation of v3 actions/upload-artifact and actions/download-artifact APIs. This change: - Updates promci from previous version to v0.4.6 - I hope resolves CI failures in artifact upload/download steps https://github.com/prometheus/promci/releases/tag/v0.4.6 https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ Signed-off-by: Raúl Naveiras <[email protected]> Signed-off-by: Tossaporn Jiw <[email protected]>
Signed-off-by: Tossaporn Jiw <[email protected]>
Signed-off-by: Tossaporn Jiw <[email protected]>
Signed-off-by: Tossaporn Jiw <[email protected]>
Signed-off-by: Tossaporn Jiw <[email protected]>
98cbaa5
to
f69c86a
Compare
@ewencodes @grobinson-grafana I have updated the default card template as per request. Is it what you are expected? |
The goal of this PR is to add an option
card
to themsteamsv2_config
configuration.If this
card
option is not used, the default behaviour is keept usingtitle
andtext
values.Here is an example screenshot of the default result in msteams channel:

When using
card
option, the user is able to customize the msteams card rendering output by using a custom template file and configuringcard
option to use this template.Here is an example screenshot of the output result in msteams channel when using

card
option:To be honest, it's the first time i'm developing in go and create a PR.
Hope it will be not so bad :)