Skip to content

Integrate Visualization Testing in Mesa CI #2734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
EwoutH opened this issue Mar 23, 2025 · 4 comments · May be fixed by #2741
Open

Integrate Visualization Testing in Mesa CI #2734

EwoutH opened this issue Mar 23, 2025 · 4 comments · May be fixed by #2741
Labels
ci Release notes label Sprints! A task that might be good to tackle during sprints! testing Release notes label visualisation

Comments

@EwoutH
Copy link
Member

EwoutH commented Mar 23, 2025 •
edited
Loading

Goal

Add comprehensive testing for Mesa's visualization components (SolaraViz) to our CI pipeline to ensure visualization functionality works correctly across all example models.

What's Been Tried

  • Basic model testing exists in test_examples.py but doesn't validate visualization components
  • PR #2491 started testing example app initialization by importing and accessing app.page
  • PR #215 in mesa-examples attempted more thorough SolaraViz testing but encountered import issues

Current Status

  • No systematic testing of visualization functionality exists in our CI
  • No performance benchmarks for visualizations
  • Basic tests only confirm models run but don't verify visualization correctness
  • The viz.py approach shows promise but needs integration with existing test infrastructure

The Solara docs might be useful: Testing with Solara

Part of #2364.
@EwoutH EwoutH added ci Release notes label testing Release notes label visualisation labels Mar 23, 2025
@Ya-shh Ya-shh mentioned this issue Mar 27, 2025
Open
Tejasv-Singh added a commit to Tejasv-Singh/mesa that referenced this issue Mar 30, 2025
@Tejasv-Singh
Add comprehensive SolaraViz testing framework
01d04a3 
- Implements testing framework for Mesa's SolaraViz visualization components
- Adds tests for component initialization, rendering, and data binding
- Creates mock Solara components for isolated testing
- Addresses issue projectmesa#2734
@Tejasv-Singh Tejasv-Singh linked a pull request Mar 30, 2025 that will close this issue
Open
@Sahil-Chhoker
Copy link
Collaborator

Hey @EwoutH, I would like some clarification on the 'visualization correctness' part you mention, does it mean correct model behaviour?

@EwoutH
Copy link
Member Author

EwoutH commented May 9, 2025

I would like some clarification on the 'visualization correctness' part you mention, does it mean correct model behaviour?

I would say it means that what happens in the models is correctly visualized.

But don't overcomplicate this issue. Most important thing is that no runtime errors occur in example models. Currently we have zero example testing of visualisation, leading to frequent hard errors.

@EwoutH EwoutH added the Sprints! A task that might be good to tackle during sprints! label May 9, 2025
@Sahil-Chhoker
Copy link
Collaborator

Sahil-Chhoker commented May 10, 2025 •
edited
Loading

If that's the case I think PR #2767 covers those cases pretty well.

@Anshuprem
Copy link

Hello @EwoutH Good Morning sir, i would like to work on this issue is it open or it has been merged?

Anshuprem added a commit to Anshuprem/mesa that referenced this issue May 30, 2025
@Anshuprem
projectmesa#2734
cdccf5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci Release notes label Sprints! A task that might be good to tackle during sprints! testing Release notes label visualisation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add comprehensive SolaraViz testing framework Tejasv-Singh/mesa
3 participants
@EwoutH @Anshuprem @Sahil-Chhoker