Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Update CRD versions #44

Open
youngnick opened this issue Jun 1, 2020 · 4 comments
Open

Update CRD versions #44

youngnick opened this issue Jun 1, 2020 · 4 comments
Labels
area/dependency Issues or PRs related to dependency changes. area/httpproxy Issues or PRs related to the HTTPProxy API. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/accepted Denotes an issue that has been triaged and determined to be valid.

Comments

@youngnick
Copy link
Member

We should update the HTTPProxy CRD spec, it will mean that no empty status: {} fields are output, now that there is a status subresource.

@youngnick youngnick self-assigned this Jun 1, 2020
@youngnick
Copy link
Member Author

Doing this should fix #41 as well.

@youngnick youngnick added area/dependency Issues or PRs related to dependency changes. area/httpproxy Issues or PRs related to the HTTPProxy API. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/accepted Denotes an issue that has been triaged and determined to be valid. labels Jun 1, 2020
youngnick pushed a commit to youngnick/ir2proxy that referenced this issue Jun 1, 2020
Fixes projectcontour#44
Fixes projectcontour#41

This commit updates the Contour dependency to v1.5.0, meaning that objects that are generated no longer
require a `status: {}` stanza in them to pass CRD validation.

However, this means that this commit also requires that Contour v1.5.0 be running in any clusters you are converting.

Signed-off-by: Nick Young <[email protected]>
@jpeach
Copy link
Contributor

jpeach commented Jul 15, 2020

We should update the HTTPProxy CRD spec

Update in what way?

@youngnick
Copy link
Member Author

Just update the dependency from v1.1.0 to v1.4.0 (I think?) whichever version was the last we had ingressroute support. I made some changes to the HTTPProxy spec that make the objects a little tidier.

@youngnick youngnick removed their assignment Feb 19, 2021
@xaleeks
Copy link

xaleeks commented Aug 17, 2021

is this still on your radar? @youngnick

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/dependency Issues or PRs related to dependency changes. area/httpproxy Issues or PRs related to the HTTPProxy API. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/accepted Denotes an issue that has been triaged and determined to be valid.
Projects
None yet
Development

No branches or pull requests

3 participants