This repository was archived by the owner on Feb 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 86
This repository was archived by the owner on Feb 27, 2023. It is now read-only.
Improve goroutine and error handling in the discoverers #225
Copy link
Copy link
Open
Labels
discoverergood first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.priority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Description
Use heptio/workgroup to improve handling of the multiple goroutines that are spawned in each of the discoverers. This will also help us to bubble up errors to main, and handle them appropriately.
An example of this is #224. We wanted to handle the case where re-auth failed 3 times, but there was no good way of bubbling up the error to main.go. We could make reconciler.Run return an error to bubble it up to main.go, and use heptio/workgroup to handle the goroutine part of it.
Metadata
Metadata
Assignees
Labels
discoverergood first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.priority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.Important over the long term, but may not be staffed and/or may need multiple releases to complete.