TLS fingerprinting enablement #7325
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gtriggiano! Welcome to our community and thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Contour better. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace |
This commit modifies the TLS Inspector instantiation to support an optional parameter for enabling JA3/JA4 fingerprinting. The following changes were made: - Updated the TLS Inspector instantiation across multiple test files to use the new parameter, defaulting to false. - Introduced a new field `EnableTLSFingerprinting` in the ListenerConfig struct to manage this feature. - Adjusted the secureProxyProtocol function to accept the new parameter and pass it to the TLS Inspector. - Updated documentation to reflect the new `enableFingerprinting` option in the API reference. Signed-off-by: Giacomo Triggiano <[email protected]>
Signed-off-by: Giacomo Triggiano <[email protected]>
gtriggiano
force-pushed
the
feature/tls-fingerprinting-enablement
branch
from
6609e06 to
39885d7
Compare
gtriggiano
requested review from
sunjayBhatia and
tsaarni
and removed request for
a team
sunjayBhatia
requested review from
a team,
clayton-gonsalves and
wilsonwu
and removed request for
a team
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7325 +/- ##
==========================================
- Coverage 81.85% 80.60% -1.25%
==========================================
Files 130 130
Lines 15747 15791 +44
==========================================
- Hits 12889 12728 -161
- Misses 2574 2607 +33
- Partials 284 456 +172
🚀 New features to boost your workflow:
|
tsaarni
reviewed
Dec 5, 2025
Comment on lines
+141
to
+142
| serve.Flag("enable-ja3-fingerprinting", "Enable JA3 fingerprinting in the TLS Inspector filter (requires Envoy 1.21.0+).").BoolVar(&ctx.enableJA3Fingerprinting) | ||
| serve.Flag("enable-ja4-fingerprinting", "Enable JA4 fingerprinting in the TLS Inspector filter (requires Envoy 1.35.0+).").BoolVar(&ctx.enableJA4Fingerprinting) |
Member
There was a problem hiding this comment.
Thank you @gtriggiano for your contribution!
I haven’t had a chance to look into this topic yet, but one quick note, something you’ve probably noticed yourself also since I saw you added config file and CRD support: we now generally avoid adding new command-line switches unless absolutely necessary, and we prefer using the config file and ContourConfiguration instead. I think we don't need to add command line flags for this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TLS Fingerprinting Support (JA3/JA4)
Enables TLS fingerprinting in Envoy's TLS Inspector listener filter for security monitoring, analytics, and bot detection. Provides independent control over JA3 and JA4 fingerprinting methods.
Configuration
ContourConfig CRD fields (under
spec.envoy.listener.tls):enableJA3Fingerprinting: Enable JA3 fingerprinting (requires Envoy 1.21.0+)enableJA4Fingerprinting: Enable JA4 fingerprinting (requires Envoy 1.35.0+)Command-line flags:
--enable-ja3-fingerprinting: Enable JA3 fingerprinting--enable-ja4-fingerprinting: Enable JA4 fingerprintingBoth settings default to
false.Implements: #7307