Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

codegen CI check can fail on release branches #432

Open
skriss opened this issue Aug 26, 2021 · 1 comment
Open

codegen CI check can fail on release branches #432

skriss opened this issue Aug 26, 2021 · 1 comment

Comments

@skriss
Copy link
Member

skriss commented Aug 26, 2021

Hmm, codegen failing because it's trying to pull Contour's main CRD YAML (which has changed). It should be looking at 1.18 YAML (which hasn't changed). Can ignore for now and follow up with a fix, I think.

Originally posted by @skriss in #431 (comment)
@skriss
Copy link
Member Author

skriss commented Aug 26, 2021

On release branches, https://github.com/projectcontour/contour-operator/blob/main/Makefile#L147-L151 has NEW_VERSION set to main, so it's pulling the main version of projectcontour/contour's CRD YAML instead of the release-branch-relevant version.

@skriss skriss mentioned this issue Feb 3, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skriss