Skip to content
This repository was archived by the owner on Jan 10, 2023. It is now read-only.

Commit c3a2a87

Browse files
mpegregkh
authored andcommitted
powerpc/mpic: Check if cpu_possible() in mpic_physmask()
[ Upstream commit 0834d62 ] In mpic_physmask() we loop over all CPUs up to 32, then get the hard SMP processor id of that CPU. Currently that's possibly walking off the end of the paca array, but in a future patch we will change the paca array to be an array of pointers, and in that case we will get a NULL for missing CPUs and oops. eg: Unable to handle kernel paging request for data at address 0x88888888888888b8 Faulting instruction address: 0xc00000000004e380 Oops: Kernel access of bad area, sig: 11 [#1] ... NIP .mpic_set_affinity+0x60/0x1a0 LR .irq_do_set_affinity+0x48/0x100 Fix it by checking the CPU is possible, this also fixes the code if there are gaps in the CPU numbering which probably never happens on mpic systems but who knows. Debugged-by: Nicholas Piggin <npiggin@gmail.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent fc2de79 commit c3a2a87

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

arch/powerpc/sysdev/mpic.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -626,7 +626,7 @@ static inline u32 mpic_physmask(u32 cpumask)
626626
int i;
627627
u32 mask = 0;
628628

629-
for (i = 0; i < min(32, NR_CPUS); ++i, cpumask >>= 1)
629+
for (i = 0; i < min(32, NR_CPUS) && cpu_possible(i); ++i, cpumask >>= 1)
630630
mask |= (cpumask & 1) << get_hard_smp_processor_id(i);
631631
return mask;
632632
}

0 commit comments

Comments
 (0)