Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename atob helper for better clarity #9

Closed
czosel opened this issue Feb 26, 2019 · 1 comment · Fixed by #300
Closed

Rename atob helper for better clarity #9

czosel opened this issue Feb 26, 2019 · 1 comment · Fixed by #300
Assignees
@czosel
Labels
enhancement New feature or request good first issue Good for newcomers released

Comments

@czosel
Copy link
Contributor

czosel commented Feb 26, 2019

From projectcaluma/ember-caluma-utils#125

The atob helper does not only call the native atob function but also does a splitting of the id. With the current name it is confusing why not just the native function was used. Better rename the helper to decodeId or something like this.
@czosel czosel self-assigned this Feb 26, 2019
@anehx anehx added enhancement New feature or request good first issue Good for newcomers labels May 16, 2019
@anehx anehx mentioned this issue May 31, 2019
Merged
@czosel
Copy link
Contributor Author

czosel commented Jun 6, 2019

🎉 This issue has been resolved in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@czosel czosel added the released label Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@czosel czosel

Labels
enhancement New feature or request good first issue Good for newcomers released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(atob): rename atob helper to decodeId anehx/ember-caluma
2 participants
@anehx @czosel