Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy without ImageMagick? #296

Open
jberkus opened this issue Apr 8, 2016 · 3 comments
Open

Deploy without ImageMagick? #296

jberkus opened this issue Apr 8, 2016 · 3 comments

Comments

@jberkus
Copy link
Contributor

jberkus commented Apr 8, 2016

@tigert, @garrett

I was building an atomicapp for doing deploys. However, the deploy builds a couple icons, and requires ImageMagick, which in Fedora pulls in all of X11. Is there a way around this?

@garrett
Copy link
Contributor

garrett commented Apr 11, 2016

Well, I think ImageMagick is mainly used for the .ico file. We could disable the favicon building and include a pre-built one instead.

I'm not sure if it is used for determining image sizes. I guess it's easy enough to check.

garrett added a commit to garrett/atomic-site that referenced this issue Apr 11, 2016
this should eliminate the need for compile-time favicon
generation... and imagemagick, which then pulled in X11 (in Fedora, *)

(this fixes projectatomic#296)
@garrett
Copy link
Contributor

garrett commented Apr 11, 2016

Just for reference, favicons are a de-facto standard originally made by Microsoft — but most other browser vendors thought it'd be a good idea to let websites have icons and adopted the idea and basic implementation. Favicons are supported in .ico format for all browsers, but most also accept PNGs now. However, PNGs only support one size and .ico files support multiple.

More info @ https://en.wikipedia.org/wiki/Favicon


It would only be necessary to update the favicon when the logo changes for whatever reason. As I don't see that happening any time soon, it should be fine to just have use precompiled version.

Even still, it's easy enough to edit the .ico in The Gimp or a favicon generator website if the time ever arises.

@garrett
Copy link
Contributor

garrett commented Apr 11, 2016

More browser-specific info @ http://caniuse.com/#search=favicon — because of Safari, Opera Mini, and older IE (<11), .ico files are still needed. We can't just use PNGs.

Also: Sadly, only Firefox properly supports .svg favicons. (They should be optimized for 16×16 if that were the case.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants