-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove automatic triage/needs-triage label creation #392
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is highly related to this one: opendatahub-io/distributed-workloads#148
and: project-codeflare/codeflare-common#8
There were thoughts of updating this workflow and moving it to the codeflare-common repo for all components to use (depending on how much work is involved, so not entirely necessary).
Should we instead then just remove that job from each repo? Which includes ODH/CFO, project-codeflare/CFO, MCAD, InstaScale, CodeFlare SDK? <-- I think I vote for this.
Are you referring to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding same comment on this PR for adjusting the first line of this file 👍
@ChristianZaccaria thanks, done |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobbins228 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9380986
into
project-codeflare:main
Issue link
What changes have been made
Remove workflow job adding triage/needs-triage label for new issues. Currently the triage is leveraging priority field.
Verification steps
Checks