Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove automatic triage/needs-triage label creation #392

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Nov 2, 2023

Issue link

What changes have been made

Remove workflow job adding triage/needs-triage label for new issues. Currently the triage is leveraging priority field.

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested review from Bobbins228 and dimakis November 2, 2023 08:50
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2023
Copy link
Collaborator

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is highly related to this one: opendatahub-io/distributed-workloads#148
and: project-codeflare/codeflare-common#8

There were thoughts of updating this workflow and moving it to the codeflare-common repo for all components to use (depending on how much work is involved, so not entirely necessary).

Should we instead then just remove that job from each repo? Which includes ODH/CFO, project-codeflare/CFO, MCAD, InstaScale, CodeFlare SDK? <-- I think I vote for this.

@sutaakar
Copy link
Contributor Author

sutaakar commented Nov 3, 2023

Should we instead then just remove that job from each repo?

Are you referring to the Add issue to project job? I think that this job still has sense, the question is how to apply it for all repositories without unnecessary duplications.

Copy link
Collaborator

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding same comment on this PR for adjusting the first line of this file 👍

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2023
@sutaakar
Copy link
Contributor Author

sutaakar commented Nov 8, 2023

@ChristianZaccaria thanks, done

@ChristianZaccaria
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2023
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 9380986 into project-codeflare:main Nov 8, 2023
3 checks passed
@sutaakar sutaakar deleted the labels branch November 8, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants