Skip to content

Commit 0f16b1e

Browse files
anishasthanaopenshift-merge-robot
authored andcommitted
Fix README release instructions and lint errors
Signed-off-by: Anish Asthana <[email protected]>
1 parent a37b227 commit 0f16b1e

File tree

1 file changed

+17
-18
lines changed

1 file changed

+17
-18
lines changed

README.md

+17-18
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@
66
An intuitive, easy-to-use python interface for batch resource requesting, access, job submission, and observation. Simplifying the developer's life while enabling access to high-performance compute resources, either in the cloud or on-prem.
77

88
For guided demos and basics walkthroughs, check out the following links:
9-
- Guided demo notebooks available [here](https://github.com/project-codeflare/codeflare-sdk/tree/main/demo-notebooks/guided-demos), and copies of the notebooks with [expected output](https://github.com/project-codeflare/codeflare-sdk/tree/main/demo-notebooks/guided-demos/notebook-ex-outputs) also available
10-
- Note that these notebooks will work with the latest `codeflare-sdk` PyPI release. For testing and experimentation with `main` branch, please use the [preview notebooks](https://github.com/project-codeflare/codeflare-sdk/tree/main/demo-notebooks/guided-demos/preview_nbs)
11-
- Additionally, we have a [video walkthrough](https://www.youtube.com/watch?v=U76iIfd9EmE) of these basic demos from June, 2023
9+
10+
- Guided demo notebooks available [here](https://github.com/project-codeflare/codeflare-sdk/tree/main/demo-notebooks/guided-demos), and copies of the notebooks with [expected output](https://github.com/project-codeflare/codeflare-sdk/tree/main/demo-notebooks/guided-demos/notebook-ex-outputs) also available
11+
- Note that these notebooks will work with the latest `codeflare-sdk` PyPI release. For testing and experimentation with `main` branch, please use the [preview notebooks](https://github.com/project-codeflare/codeflare-sdk/tree/main/demo-notebooks/guided-demos/preview_nbs)
12+
- Additionally, we have a [video walkthrough](https://www.youtube.com/watch?v=U76iIfd9EmE) of these basic demos from June, 2023
1213

1314
Full documentation can be found [here](https://project-codeflare.github.io/codeflare-sdk/)
1415

@@ -54,7 +55,6 @@ To build the python package: `$ poetry build`
5455

5556
## Release Instructions
5657

57-
5858
### Automated Releases
5959

6060
It is possible to use the Release Github workflow to do the release. This is generally the process we follow for releases
@@ -63,19 +63,18 @@ It is possible to use the Release Github workflow to do the release. This is gen
6363

6464
The following instructions apply when doing release manually. This may be required in instances where the automation is failing.
6565

66-
* Check and update the version in "pyproject.toml" file.
67-
* Generate new documentation.
66+
- Check and update the version in "pyproject.toml" file.
67+
- Generate new documentation.
6868
`pdoc --html -o docs src/codeflare_sdk && pushd docs && rm -rf cluster job utils && mv codeflare_sdk/* . && rm -rf codeflare_sdk && popd && find docs -type f -name "*.html" -exec bash -c "echo '' >> {}" \;` (it is possible to install **pdoc** using the following command `poetry install --with docs`)
69-
* Commit all the changes to the repository.
70-
* Create Github release (https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository#creating-a-release).
71-
* Build the Python package. `poetry build`
72-
* If not present already, add the API token to Poetry.
69+
- Commit all the changes to the repository.
70+
- Create Github release (<https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository#creating-a-release>).
71+
- Build the Python package. `poetry build`
72+
- If not present already, add the API token to Poetry.
7373
`poetry config pypi-token.pypi API_TOKEN`
74-
* Publish the Python package. `poetry publish`
75-
* Change directory to custom-nb-image. `cd custom-nb-image`
76-
* Set tag `export tag=TAG`
77-
* Build the Docker image. `docker build --build-arg SDK_VERSION=<version> -t quay.io/project-codeflare/notebook:${tag} .`
78-
* Tag the image as latest. `docker tag quay.io/project-codeflare/notebook:${tag} quay.io/project-codeflare/notebook:latest`
79-
* Login to quay.io. `docker login quay.io`
80-
* Push the image. `docker push quay.io/project-codeflare/notebook:${tag}`
81-
* Push the image. `docker push quay.io/project-codeflare/notebook:latest`
74+
- Publish the Python package. `poetry publish`
75+
- Change directory to custom-nb-image. `cd custom-nb-image`
76+
- Set tag `export tag=TAG`
77+
- Build the container image. `podman build --build-arg SDK_VERSION=<version> -t quay.io/project-codeflare/notebook:${tag} .`
78+
- Login to quay.io. `podman login quay.io`
79+
- Push the image. `podman push quay.io/project-codeflare/notebook:${tag}`
80+
- Push the stable image tag `podman push quay.io/project-codeflare/notebook:${tag} quay.io/project-codeflare/notebook:stable`

0 commit comments

Comments
 (0)