Add common workflow to be consumed by all components #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewers: @astefanutti @sutaakar |
sutaakar
reviewed
Oct 25, 2023
| name: Common Workflow | ||
|
|
||
| on: | ||
| workflow_call: |
There was a problem hiding this comment.
Have you considered to make this a composite action, like https://github.com/project-codeflare/codeflare-operator/blob/main/.github/actions/kind/action.yml ?
Such action can be then called using https://github.com/project-codeflare/codeflare-operator/blob/main/.github/workflows/e2e_tests.yaml#L48-L49 .
However such approach still need to have workflow file in every repository.
Thinking if the application approach (like OpenShift CI) would have sense or whether it would be an overkill.
4 tasks
|
This PR is no longer needed. The workflow has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
Resolves #7
What changes have been made
Added common-workflow to add created issues from our repos to Sprint Board
All repos will be able to run this common workflow once they are each updated to call the mentioned workflow.
See issue for more context
Verification steps
I think the only way of testing this would be by:
If successful, we can proceed for all other repos.